[6.x] Speed up Stache warming for large structured collections#14781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warming a structured collection got slower and slower as entries piled up. Each entry resolved its order, URI and parent from the structure tree and every one of those lookups rebuilt a full keyed map over all pages from scratch. The flattened page list was cached but the derived maps weren't. In this commit they are now memorized and built once per tree.
Most sites will never hit this issue. It only adds up when:
10000 entry structured collection:
stache:warm: ~117s => ~59s. 🚤💨