Add support for react-router@5.0.0#273
Conversation
|
Can you please release alpha version if this is taking time to merge? |
|
This will close #274. |
|
This was spoken about in another issue, but is there any reason to have the peer dependency be on |
|
Any updates on this issue? I have forked and merged @cmfcmf 's PR for now, but an official update would be great! Thanks |
Wouldn't that mean that this package won't work with React Native? #194 and #148 indicate that it might be possible to get it working with React Native. |
|
That is a question for @supasate for sure - is this meant to be for the browser or for native applications or both? |
|
This library uses Router component from react-router. I can't say about React Native because I don't use it, but, from #194, it seems to work. |
|
@cmfcmf Can you help rebase to resolve the conflict? |
|
I just try on react-router@^5.0.0 with connected-react-router@^6.3.2, it seem to be un-compatibility. didn't pass router store to child component. After downgrade react-router and react-router-dom pacakge version (@^4.3.4) everything working fine again. I'm trying to fix this issue and PR (If i'm not too busy), looking for any reply. |
Done! |
|
Any news on this? |
|
Thanks for your contribution! |

This updates the
package.jsonfile to add compatibility with react-router@^5.0.0. Even though the major version ofreact-routerchanged, it is fully backwards compatible:-- https://github.com/ReactTraining/react-router/releases/tag/v5.0.0
Further information: remix-run/react-router#6643