Skip to content

Add support for react-router@5.0.0#273

Merged
supasate merged 2 commits into
supasate:masterfrom
cmfcmf:react-router-5
Apr 14, 2019
Merged

Add support for react-router@5.0.0#273
supasate merged 2 commits into
supasate:masterfrom
cmfcmf:react-router-5

Conversation

@cmfcmf

@cmfcmf cmfcmf commented Mar 18, 2019

Copy link
Copy Markdown
Contributor

This updates the package.json file to add compatibility with react-router@^5.0.0. Even though the major version of react-router changed, it is fully backwards compatible:

Despite the major bump, this is actually a minor release. It is fully backwards compatible with any project coming from 4.x. Sorry for the convenience. 😬

-- https://github.com/ReactTraining/react-router/releases/tag/v5.0.0

Further information: remix-run/react-router#6643

@sidag95

sidag95 commented Mar 20, 2019

Copy link
Copy Markdown

Can you please release alpha version if this is taking time to merge?

@mikecousins

Copy link
Copy Markdown

This will close #274.

@imjoshdean-tc

Copy link
Copy Markdown

This was spoken about in another issue, but is there any reason to have the peer dependency be on react-router vs react-router-dom? Currently if you use react-router-dom, which is what is recommend you do for browser based applications you get an unmet peer dependency warning from this package and it would be great to fix that.

@sidag95

sidag95 commented Mar 27, 2019

Copy link
Copy Markdown

Any updates on this issue? I have forked and merged @cmfcmf 's PR for now, but an official update would be great! Thanks

@cmfcmf

cmfcmf commented Mar 28, 2019

Copy link
Copy Markdown
Contributor Author

This was spoken about in another issue, but is there any reason to have the peer dependency be on react-router vs react-router-dom? Currently if you use react-router-dom, which is what is recommend you do for browser based applications you get an unmet peer dependency warning from this package and it would be great to fix that.

Wouldn't that mean that this package won't work with React Native? #194 and #148 indicate that it might be possible to get it working with React Native.

@imjoshdean-tc

Copy link
Copy Markdown

That is a question for @supasate for sure - is this meant to be for the browser or for native applications or both?

@supasate

supasate commented Apr 1, 2019

Copy link
Copy Markdown
Owner

This library uses Router component from react-router. I can't say about React Native because I don't use it, but, from #194, it seems to work.

@supasate

supasate commented Apr 1, 2019

Copy link
Copy Markdown
Owner

@cmfcmf Can you help rebase to resolve the conflict?

@genexu

genexu commented Apr 1, 2019

Copy link
Copy Markdown

I just try on react-router@^5.0.0 with connected-react-router@^6.3.2, it seem to be un-compatibility. didn't pass router store to child component.

After downgrade react-router and react-router-dom pacakge version (@^4.3.4) everything working fine again.

螢幕快照 2019-04-01 下午6 21 08

I'm trying to fix this issue and PR (If i'm not too busy), looking for any reply.

@cmfcmf

cmfcmf commented Apr 1, 2019

Copy link
Copy Markdown
Contributor Author

@cmfcmf Can you help rebase to resolve the conflict?

Done!

@vbartusevicius

Copy link
Copy Markdown

Any news on this?

@supasate
supasate merged commit d327b90 into supasate:master Apr 14, 2019
@supasate

Copy link
Copy Markdown
Owner

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants