add fedora43, remove fedora40#5329
Conversation
Summary of ChangesHello @mirostauder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request systematically updates the project's build environment to incorporate the latest Fedora release, Fedora 43, while simultaneously phasing out support for the older Fedora 40. The changes ensure that the build process remains current with operating system advancements, affecting both Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughFedora version entries were advanced: packaging lists in the Makefile now include fedora42 and fedora43 (replacing older fedora40/41/42 variants for amd64 and arm64). docker-compose services for Fedora builds were renamed/updated (removed fedora40 group, migrated fedora41→fedora42→fedora43) with image tag and PKG_RELEASE updates. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly updates the build configuration to add support for Fedora 43 and remove Fedora 40. The changes in the Makefile and the removal of Fedora 40 services from docker-compose.yml are appropriate. However, I've noticed an inconsistency in the Docker image tags used for the new Fedora 43 build services, which should be addressed to ensure consistency and prevent potential build issues.
| fedora43_build: | ||
| extends: | ||
| service: _build | ||
| image: proxysql/packaging:build-fedora43-v3.0.6 |
There was a problem hiding this comment.
The Docker image tag uses version v3.0.6, which is inconsistent with all other build services in this file that use v3.0.3. To maintain consistency across build environments and prevent potential build failures if the image doesn't exist, it's recommended to use v3.0.3.
image: proxysql/packaging:build-fedora43-v3.0.3| fedora43_clang_build: | ||
| extends: | ||
| service: fedora43_build | ||
| image: proxysql/packaging:build-clang-fedora43-v3.0.6 |
There was a problem hiding this comment.
The Docker image tag uses version v3.0.6, which is inconsistent with all other build services in this file that use v3.0.3. To maintain consistency across build environments, it's recommended to use v3.0.3 here as well.
image: proxysql/packaging:build-clang-fedora43-v3.0.3
There was a problem hiding this comment.
Pull request overview
This PR updates the build infrastructure to support Fedora 43 while removing support for the older Fedora 40. The changes ensure that package builds are maintained for currently supported Fedora versions (41, 42, and 43) across both amd64 and arm64 architectures.
Changes:
- Removed Fedora 40 build service definitions from docker-compose.yml
- Added Fedora 43 build service definitions (standard, clang, and debug variants) to docker-compose.yml
- Updated Makefile targets to replace fedora40 with fedora43 for both amd64 and arm64 package builds
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| docker-compose.yml | Removed fedora40_build, fedora40_clang_build, and fedora40_dbg_build services; added fedora43_build, fedora43_clang_build, and fedora43_dbg_build services using v3.0.6 build images |
| Makefile | Updated amd64-fedora and arm64-fedora targets to include fedora43 and exclude fedora40 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Fedora 41 is already EOL , I don't think we should add it |
|
@copilot : remove also support for Fedora 41 |
|
@renecannao I've opened a new pull request, #5338, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: renecannao <3645227+renecannao@users.noreply.github.com>
Remove Fedora 40 and 41 support, add Fedora 43
|
add new package builds for fedora43
remove old fedora40
Summary by CodeRabbit