fix: time_span_tags wrong case on edit tag#212
Merged
Conversation
jmattheis
approved these changes
Jun 3, 2025
jmattheis
left a comment
jmattheis
left a comment
Member
There was a problem hiding this comment.
Thanks, for future PRs please create a test if it's possible without much effort.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I managed to reproduce the bug in #131. On editing a tag to have uppercase letters, the actual tag saved in
tag_definitionswill be lower case but the update query fortime_span_tagsuses the value as is without lower-casing it.The fix should prevent that. not sure if/where I should add test cases for it.