This repository was archived by the owner on Jun 24, 2026. It is now read-only.
Show black diff on travis builds#1565
Merged
Merged
Conversation
TLDR: This is not helpful when looking at `lint` build output:
```
$ black --check manticore/core/smtlib/solver.py
would reformat manticore/core/smtlib/solver.py
Oh no! 💥 💔 💥
1 file would be reformatted.
```
And this is more helpful:
```
$ black --diff --check manticore/core/smtlib/solver.py
--- manticore/core/smtlib/solver.py 2019-11-24 11:14:37.431508 +0000
+++ manticore/core/smtlib/solver.py 2019-11-24 12:09:00.461367 +0000
@@ -149,13 +149,11 @@
self._proc: Popen = None
# z3 parameters can be listed via `z3 -p` and set on the CLI
parameters = "parallel.enable=true"
- self._command = (
- f"{consts.z3_bin} -t:{consts.timeout*1000} -memory:{consts.memory} -smt2 {parameters} -in"
- )
+ self._command = f"{consts.z3_bin} -t:{consts.timeout*1000} -memory:{consts.memory} -smt2 {parameters} -in"
# Commands used to initialize z3
self._init = [
# http://smtlib.cs.uiowa.edu/logics-all.shtml#QF_AUFBV
# Closed quantifier-free formulas over the theory of bitvectors and bitvector arrays extended with
would reformat manticore/core/smtlib/solver.py
Oh no! 💥 💔 💥
1 file would be reformatted.
```
disconnect3d
force-pushed
the
travis-diff-black
branch
from
November 24, 2019 12:38
ba78fcd to
f8814c5
Compare
reaperhulk
approved these changes
Nov 24, 2019
ekilmer
added a commit
that referenced
this pull request
Dec 17, 2019
* master: (33 commits) removes travis entirely (#1572) Run mypy on manticore directory by default (#1573) Fix deprecation warnings related to setting verbosity (#1574) Bump version to fix pip install on Python 3.6 (#1571) Direct CI badge directly to CI action (#1570) switch to github actions (take two) (#1568) Add --quick-mode to configure Manticore for fast exploration (#1555) pytest-xdist prevents disturbing stdout, revert to travis_wait (#1566) Show black diff on travis builds (#1565) various changes to resolve test timeout/invalid dep issues (#1563) try pytest xdist (#1561) switch to pytest (#1560) Fixes different problems found by lgtm (#1558) reorg some deps a bit, usee env markers for dataclasses (#1559) fix some deprecation warnings (#1556) Add flag to only generate alive states when finalizing Manticore (#1554) Arrayvarname (#1552) Fix Z3 version parsing (#1551) Update README.md (#1553) Manticore 0.3.2 (#1547) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR: This is not helpful when looking at
lintbuild output:And this is more helpful: