This repository was archived by the owner on Jun 24, 2026. It is now read-only.
Revert default gas limit#1689
Merged
Merged
Conversation
Reverts one of the changes from #1652 to fix the sporadically-failing `test_integer_overflow_multitx_onefunc_feasible` test in `ethereum_bench`
Contributor
Author
|
@feliam Do you have thoughts on this? Is removing the gas limit a sane default behavior, or should we raise it up from what it was? |
Contributor
|
I wonder Where and why a unittest is relying on the default. I move that to None to try detecting those. |
ekilmer
added a commit
that referenced
this pull request
May 18, 2020
* master: (24 commits) Fix symbolic syscall arg concretization (#1697) Update README, Add Issue Templates (#1685) Fix inheritance magic and add plugin enable/disable (#1696) Add hashing to constraintSets (#1703) Reduce log messages (#1700) Updated Proc error message to be more informative (#1704) Move states that selfdestruct to the ready queue. (#1699) Reduce concrete hash log messages. (#1695) Remove Keystone from existing tests (#1684) Change URL for WASM spec (#1702) Overhaul Linux file emulation (#1673) Try getting more coverage from truffle-test (#1694) Eliminate deprecation warning in solidity_create_contract. (#1692) Fix a few documentation typos in ManticoreBase (#1687) Add set_verbosity to the documentation (#1688) Adjust z3 options. (#1691) Improve concretize log messages (#1686) Move truffle to its own CI type (#1693) Remove default gas limit (#1689) Better argument names in manticoreEVM api (#1652) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts one of the changes from #1652 to fix the sporadically-failing
test_integer_overflow_multitx_onefunc_feasibletest inethereum_bench