This repository was archived by the owner on Jan 3, 2024. It is now read-only.
[BREAKING] Remove upload and release functions to prepare for CI step.#144
Merged
Conversation
We are going to these in CI workflows instead. This change greatly simplifies the project.
robertsLando
suggested changes
Mar 31, 2021
robertsLando
left a comment
robertsLando
left a comment
Contributor
There was a problem hiding this comment.
Looks good overall. BTW I would replace request with got or another module as request is deprecated, also I would use semver to get major version instead of using a custom method
Contributor
Author
Well. I just moved things around. |
robertsLando
approved these changes
Mar 31, 2021
robertsLando
left a comment
robertsLando
left a comment
Contributor
There was a problem hiding this comment.
Ok no problem. LGTM
leerob
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are going to these in CI workflows instead.
This change greatly simplifies the project.
FYI: This is semver-major.