Skip to content
This repository was archived by the owner on Jan 3, 2024. It is now read-only.

CI: output to dist/ with "node-*" prefix#156

Merged
jesec merged 3 commits into
masterfrom
pr/output
Apr 7, 2021
Merged

CI: output to dist/ with "node-*" prefix#156
jesec merged 3 commits into
masterfrom
pr/output

Conversation

@jesec

@jesec jesec commented Apr 7, 2021

Copy link
Copy Markdown
Contributor

No description provided.

@jesec
jesec requested review from leerob and robertsLando April 7, 2021 01:10

@robertsLando robertsLando left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for info why node- prefix and not fetched ?

@jesec

jesec commented Apr 7, 2021

Copy link
Copy Markdown
Contributor Author

Just for info why node- prefix and not fetched ?

Because they are binaries to be uploaded.

@robertsLando

Copy link
Copy Markdown
Contributor

@jesec Sorry I mean uploaded-, AFAIK pkg looks for that?

@jesec

jesec commented Apr 7, 2021

Copy link
Copy Markdown
Contributor Author

@jesec Sorry I mean uploaded-, AFAIK pkg looks for that?

See #149.

@robertsLando robertsLando left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Forgot that. Sorry, LGTM

@jesec
jesec merged commit 549db84 into master Apr 7, 2021
@jesec
jesec deleted the pr/output branch April 7, 2021 09:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants