Skip to content
This repository was archived by the owner on Jan 3, 2024. It is now read-only.

build: don't strip global symbols of macOS binaries#180

Merged
jesec merged 1 commit into
masterfrom
pr/no-strip-global
May 10, 2021
Merged

build: don't strip global symbols of macOS binaries#180
jesec merged 1 commit into
masterfrom
pr/no-strip-global

Conversation

@jesec

@jesec jesec commented May 10, 2021

Copy link
Copy Markdown
Contributor

Global symbols are required for native bindings on macOS.

Bug: vercel/pkg#1155

@jesec
jesec requested a review from robertsLando May 10, 2021 15:40

@robertsLando robertsLando left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jesec
jesec merged commit 5d2bc3b into master May 10, 2021
@jesec
jesec deleted the pr/no-strip-global branch May 10, 2021 15:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants