patches: bump to 14.20.1, 16.17.1, and 18.9.1

[emahfoud]

related to https://github.com/vercel/pkg-fetch/issues/257

[jesec]

Thanks for the PR. LG2M in general.

Have you run the patches to ensure there is no delta/conflict?

[emahfoud]

I ran yarn start --node-range node16 --arch x64 --output dist for 14, 16, and 18 on windows and it generated artifacts and checksums without errors. Is that what you meant? Are there test suites I should run? And should I generate artifacts for all platforms before doing that?

I assumed the workflow to be like this:

• submit the PR
• Merge approved PR (to be done by someone with write access)
• Get the artifacts generated by the pipeline
• Generate the hashes for these artifacts and commit them to the expected.ts
• Send another PR to update the the hashes
• Create a new release (to be done by someone with write access)

Is that correct?

[emahfoud]

Those are the tests I'm aware of (they're run in the pipeline for the PR)
https://github.com/vercel/pkg-fetch/actions/runs/3163215418

[emahfoud]

@jesec Is there anything else I should do?

[jesec]

I was on a business trip last two weeks. Thanks for your patience.

I ran yarn start --node-range node16 --arch x64 --output dist for 14, 16, and 18 on windows and it generated artifacts and checksums without errors. Is that what you meant? Are there test suites I should run? And should I generate artifacts for all platforms before doing that?

I want to make sure that the patches are perfectly applied. Check if there is something like "applied with offset" in the log.

I assumed the workflow to be like this:

• submit the PR
• Merge approved PR (to be done by someone with write access)
• Get the artifacts generated by the pipeline
• Generate the hashes for these artifacts and commit them to the expected.ts
• Send another PR to update the the hashes
• Create a new release (to be done by someone with write access)

Is that correct?

I will do other steps.

[baparham]

@emahfoud this can probably be closed since it's covered by #260 and #269

[baparham]

I'm glad someone else is pushing patches to this project too :-) Thanks for the contributions!