patches: bump to 18.13.0, 16.19.0 and 14.21.2#269
Conversation
|
@robertsLando can you give this a look? |
844abad to
a04e2ff
Compare
|
There are some steps here to verify the patches have been created successfully - can we try those? And then let's document in the README those steps for the next PR 👍 |
Meant to tag @leerob in this reply |
|
@leerob I created a merged PR in my fork to test these patches against the new patch application test added in #251 so that we don't have to wait to get that merged in before testing this patch set with it. |
|
@leerob Could you publish this to npm ? |
+1 |
|
AFAIK we can't publish until we get ARM support working, any help you can provide over in #276 would be greatly appreciated. I agree that we need to publish this as soon as possible. In the meantime, there are a few workarounds suggested to build your own binaries in your own fork, and patch your local copy of I'll see if I can post a quick, how-to for such a workaround in the next day or so in the meantime to sorting out the ARM builds. |
|
Thank you @baparham . A how-to for a workaround would be greatly appreciated. |
|
@baparham Brad, i can get you AWS credits. can you share your email address? For context, Kamil and I work in the same team. |
|
@sobolk I'm still trying to find some time to document the details, but here is the top level summary. Each portion is surely searchable on your favorite search engine :-) It basically boils down to these steps:
|
|
Check this: https://github.com/yao-pkg/pkg-binaries#usage Used it in a gh workflow here: https://github.com/zwave-js/zwave-js-ui/blob/master/.github/workflows/package_armv7.yml#L55 |
All patches apply cleanly