This repository was archived by the owner on Jan 3, 2024. It is now read-only.
patches: fix toLocalChecked use in 18.13.0#273
Merged
Conversation
Contributor
Author
|
I have a build running over in my fork with this patch cherry-picked in https://github.com/baparham/pkg-fetch/actions/runs/4064871015 <- EDIT: this has unusable arm builds in it that depend on self hosted runners in @jesec 's fork, so I kicked off another build-all without arm (except windows) https://github.com/baparham/pkg-fetch/actions/runs/4065087301 |
baparham
marked this pull request as ready for review
February 1, 2023 18:24
Contributor
Author
|
https://github.com/baparham/pkg-fetch/actions/runs/4065087301 built the assets, and windows build worked to package a cli for me, so I think this was the only fix required. |
robertsLando
approved these changes
Feb 2, 2023
Contributor
|
@leerob 👍🏼 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to cobble together the fixes for the
v18.13.0patch.For starters, the identity of
v8_scriptseemed to change from aMaybeLocal<UnboundScript>to be aLocal<UnboundScript>so we should no longer calltoLocalChecked()on it.Other changes...I do not know, I'll build from here and see where that leads.
As usual, I am totally open to feedback and advice on this.
This is meant to fix #272