Skip to content
This repository was archived by the owner on Jan 3, 2024. It is now read-only.

patches: bump to 14.21.3, 16.19.1, 18.14.1, and 19.6.1#277

Merged
robertsLando merged 1 commit into
vercel:mainfrom
baparham:patches
Feb 17, 2023
Merged

patches: bump to 14.21.3, 16.19.1, 18.14.1, and 19.6.1#277
robertsLando merged 1 commit into
vercel:mainfrom
baparham:patches

Conversation

@baparham

@baparham baparham commented Feb 17, 2023

Copy link
Copy Markdown
Contributor

Updates to that recent security releases made by Node.js team, specifically around OpenSSL. See their blog post for details about the specific CVEs this resolves.

Fixes #275

@baparham

Copy link
Copy Markdown
Contributor Author

hm, Node16 failed to print any output on the applyPatches test, almost like the output wasn't flushed to stdout or something, or there was a timeout or something. I can't exactly explain why it failed, but that's disappointing that it's flakey like that. I force pushed again with no changes and it passed the second time.

@baparham

Copy link
Copy Markdown
Contributor Author

Running a full (non-ARM) set of builds to verify these patches still build based on this patch here: https://github.com/baparham/pkg-fetch/actions/runs/4203687943

@robertsLando

Copy link
Copy Markdown
Contributor

Is this good to merge?

@baparham

Copy link
Copy Markdown
Contributor Author

I don't think so, the builds on windows node 18 seem to have failed, so probably needs some due diligence

@baparham

Copy link
Copy Markdown
Contributor Author

failures look unrelated, so I'll retry them when the other builds are done:

https://github.com/baparham/pkg-fetch/actions/runs/4203687943/jobs/7293401466#step:5:14

@robertsLando

Copy link
Copy Markdown
Contributor

LMK

@baparham

Copy link
Copy Markdown
Contributor Author

@robertsLando builds look clean, we can merge this in

@robertsLando
robertsLando merged commit de53837 into vercel:main Feb 17, 2023
@baparham
baparham deleted the patches branch February 18, 2023 09:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

need to enable support to node LTS 18.14.1

2 participants