Skip to content
This repository was archived by the owner on Jan 3, 2024. It is now read-only.

Revive cross compile and bump patches to latest#280

Merged
baparham merged 7 commits into
vercel:mainfrom
baparham:revive-cross-compile
Mar 15, 2023
Merged

Revive cross compile and bump patches to latest#280
baparham merged 7 commits into
vercel:mainfrom
baparham:revive-cross-compile

Conversation

@baparham

@baparham baparham commented Mar 8, 2023

Copy link
Copy Markdown
Contributor
  • This re-enables cross-compiling for ARM on x86, using the fix proposed in build: fix arm64 cross-compilation nodejs/node#45756
  • Bumps patches to 18.15.0 and 19.7.0.
  • Adds a build-all.yml workflow to kick off and wait for all assets to build. To be added on to later with some more automated hash checking, perhaps some more tests (at least on x86) to ensure the built binaries are functional, etc.

There is currently a debug commit at the end to allow me to run the full build-all workflow to build all current assets on push to this revive-cross-compile branch, which I'll take out once I see the builds all succeed.

This would fix #276

@baparham

baparham commented Mar 8, 2023

Copy link
Copy Markdown
Contributor Author

Full build workflow running over in my fork for this branch here: https://github.com/baparham/pkg-fetch/actions/runs/4368413726

That really needs to pass to be sure the builds aren't broken, but I also have no way of actually runtime testing the arm binaries. Can someone else help out with testing those out once they are built to be sure ARM builds are in fact still working when cross compiled?

@robertsLando

Copy link
Copy Markdown
Contributor

@baparham I can

@mertushka

mertushka commented Mar 10, 2023

Copy link
Copy Markdown

🤞 Lets make PKG great again. 😅

@ospencer

Copy link
Copy Markdown

Hey @baparham, I tested these on an M1 Mac using Docker, and they all appear to work. Here's a repo if anyone wants to reproduce: https://github.com/ospencer/test-pkg-fetch

It's a pretty basic hello world smoke test, but I figured that was sufficient.

@ospencer

Copy link
Copy Markdown

(To clarify, specifically I tested the Linux arm64 binaries—not sure if you need alpine, Windows, and friends tested too.)

@baparham

Copy link
Copy Markdown
Contributor Author

Seems to be enough confirmation for me, @robertsLando shall we merge this in?

@baparham

Copy link
Copy Markdown
Contributor Author

ah, not quite yet, I need to drop the last debug commit first, I'll push again

@baparham
baparham force-pushed the revive-cross-compile branch from 7a68ea6 to 9aaccd4 Compare March 15, 2023 08:33
@robertsLando

Copy link
Copy Markdown
Contributor

Sorry for late feedback, have been very busy last weeks, yeah let's do this :)

@baparham
baparham merged commit 4be7c66 into vercel:main Mar 15, 2023
@baparham
baparham deleted the revive-cross-compile branch March 15, 2023 11:06
@phated

phated commented Mar 15, 2023

Copy link
Copy Markdown
Contributor

@robertsLando Are you also planning to do a release? 🙏

@mertushka

Copy link
Copy Markdown

Release wouldnt hurt 🙏

@robertsLando

Copy link
Copy Markdown
Contributor

Wish I could do it, don't have the privileleges, need to ask @leerob via private email. @baparham Would you like to inform him? This should be a minor

@baparham

Copy link
Copy Markdown
Contributor Author

Yeah, I'll reach out to him. In the meantime we could probably try and sneak in the latest 19.8.1 patch set too while we wait till US west coast time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable cross compiling for ARM

5 participants