patches: bump to 19.8.1#284
Conversation
robertsLando
left a comment
There was a problem hiding this comment.
@baparham I'm not a master in patches but for what I can see it looks goot to me, tried to test the result patch ?
|
I'll kick off https://github.com/baparham/pkg-fetch/actions/runs/4436328574/jobs/7784623159 and then test out the windows x64 binary for node 19 when that's done (assuming it builds, haha!) |
|
I am not confident with this patch. I tried upgrading to it with a project that was using node18, and it hits this issue: but I'm not sure what's related to upgrading from node18 to node19 in my client application, or what's related to a bad patch. This error makes me believe that this is in the node patches rather than in my userspace code. I think this needs more tests, so perhaps this shouldn't block a release. However, I have no idea if this issue affects the older node19 patches as well. |
|
ugh, I completely forgot that I also need https://github.com/vercel/pkg/pull/1862/files for this to work. Good opportunity to test that patch out I guess!! |
works now 🙄 so I think this can be merged |
No description provided.