fix: patch issues with workers #282

[matthias-heller]

As described in https://github.com/vercel/pkg-fetch/issues/282 there is an issue with workers starting from node.js 18.14.1. This fix solves this issue for 18.15.0 as well as 19.8.1

[baparham]

building assets here to test that these patches build in CI

[robertsLando]

@baparham Can I merge this?

[baparham]

builds are still running, but looking positive. I'd like to test out the binary myself (to ensure we didn't break non-worker usage) before saying yes

[robertsLando]

ok LMK

[baparham]

I tried running with windows x64 18.15.0 from the CI builds, but pkg was complaining it can't find the placeholder. I may have setup my test incorrectly with the wrong cache or something applied, but I won't be able to come back and try again right away, just to let you know what the status is. I'm not 100% confident in this quite yet but I appreciate your patience.

[baparham]

giving this another look today, FYI

[baparham]

OK, so I tested it out with a bare bones pkg hello world test for workers and main threads and it seems OK. I'm not sure what I was doing wrong in my production repo, so hopefully this doesn't break that use case 😬

[robertsLando]

Good to know! Good to merge so? 🚀

[baparham]

yep!