Skip to content

Add space in cascade SQL and fix docs.#1153

Merged
parsonsmatt merged 6 commits into
yesodweb:masterfrom
ldub:friedbrice/add-space-in-cascade-sql
Nov 5, 2020
Merged

Add space in cascade SQL and fix docs.#1153
parsonsmatt merged 6 commits into
yesodweb:masterfrom
ldub:friedbrice/add-space-in-cascade-sql

Conversation

@friedbrice

@friedbrice friedbrice commented Nov 5, 2020

Copy link
Copy Markdown
Contributor

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Bumped the version number if there isn't an (unreleased) on the Changelog
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Comment thread persistent/ChangeLog.md Outdated
@friedbrice friedbrice changed the title Friedbrice/add space in cascade sql Add space in cascade SQL and fix docs. Nov 5, 2020
Co-authored-by: Matt Parsons <parsonsmatt@gmail.com>
@friedbrice friedbrice closed this Nov 5, 2020
@friedbrice friedbrice reopened this Nov 5, 2020
@friedbrice

Copy link
Copy Markdown
Contributor Author

Good to go. Thanks @parsonsmatt!

@parsonsmatt parsonsmatt merged commit 32a9421 into yesodweb:master Nov 5, 2020
parsonsmatt added a commit that referenced this pull request Nov 5, 2020
* add space in cascade sql

* fix doc string

* bump versions

* add changelog entry

* add link in changelog

* Update persistent/ChangeLog.md

Co-authored-by: Matt Parsons <parsonsmatt@gmail.com>

Co-authored-by: Matt Parsons <parsonsmatt@gmail.com>
@friedbrice friedbrice deleted the friedbrice/add-space-in-cascade-sql branch November 5, 2020 19:05
@friedbrice

friedbrice commented Nov 5, 2020

Copy link
Copy Markdown
Contributor Author

Hi, @parsonsmatt. I noticed persistent-2.11.0.1 made it to Hackage successfully, but could you please also upload persistent-postgresql-2.11.0.1 to Hackage as well? Thanks!

(If Hackage upload is automated and the bots just haven't gotten around to it yet, I'm sorry!)

@parsonsmatt

Copy link
Copy Markdown
Collaborator

There weren't any changes made to persistent-postgresql in this PR, so I reverted the version bump.

@friedbrice

friedbrice commented Nov 5, 2020

Copy link
Copy Markdown
Contributor Author

Oh! I'm so sorry. I was just confused then. I thought the ON DELETE -> ON DELETE was in a file in the postgresql package. Thanks much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants