Skip to content

Add type application to selectList documentation.#1392

Merged
parsonsmatt merged 5 commits into
yesodweb:masterfrom
friedbrice:master
Apr 27, 2022
Merged

Add type application to selectList documentation.#1392
parsonsmatt merged 5 commits into
yesodweb:masterfrom
friedbrice:master

Conversation

@friedbrice

@friedbrice friedbrice commented Apr 15, 2022

Copy link
Copy Markdown
Contributor

Before submitting your PR, check that you've:

  • Ran stylish-haskell on any changed files.
  • Adhered to the code style (see the .editorconfig file for details)

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

Suggest type application for situations where the `record` type cannot be inferred.
enhance clarity
fix name of extension
@friedbrice

Copy link
Copy Markdown
Contributor Author

Hmm, the build failure appears to be unrelated to my change.

@friedbrice

friedbrice commented Apr 16, 2022

Copy link
Copy Markdown
Contributor Author

@parsonsmatt Thanks for re-running my build. It's a strange error. If I'm reading it right, it says there's a missing shared library? How, even? FWIW (though I know it's not much), the project builds on my machine with GHC 9.0.x

@parsonsmatt

Copy link
Copy Markdown
Collaborator

urge to switch back to stack based build rising

@parsonsmatt

Copy link
Copy Markdown
Collaborator

It looks like 9.0 is just bad on CI. Trying out 9.0.2.

@parsonsmatt

Copy link
Copy Markdown
Collaborator

Can you merge master and try again?

@friedbrice

Copy link
Copy Markdown
Contributor Author

@parsonsmatt Passed CI under GHC 9.0.2 :-D

@parsonsmatt parsonsmatt merged commit b876130 into yesodweb:master Apr 27, 2022
@parsonsmatt

Copy link
Copy Markdown
Collaborator

Thanks! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants