Keep inline code pipes inside markdown table cells#57744
Merged
smitbarmase merged 7 commits intoJun 26, 2026
Merged
Conversation
8e42222 to
fa7c53f
Compare
Co-authored-by: Tom Houlé <tom@tomhoule.com>
fa7c53f to
f5a40c1
Compare
smitbarmase
approved these changes
Jun 26, 2026
smitbarmase
left a comment
Member
There was a problem hiding this comment.
Thanks,@tomhoule and I decided to go forward with only the GFM approach, i.e., rendering \| as | in tables, but we don't think we need a more generic case for now, since it introduces a lot of complexity and maintainability burden. I think this should be enough for most cases. Thanks again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes markdown table rendering when inline code spans contain pipe characters. Code such as
`a|b`and`a||b`now stays in one table cell instead of being split into extra columns.Why
Agent output and markdown previews can include regexes, shell snippets, and other code spans with
|characters inside tables. Before this change, those pipes could be parsed as table delimiters even though they were part of inline code.Changes
pulldown-cmarkparses tables.Manual check: generated agent responses across multiple models render tables containing
`a|b`,`(a|b)`, and`a||b`as single code-span cells rather than split columns.Screenshots / Recordings
Self-Review Checklist
Closes #57683
Release Notes: