Fix update version button stuck on "Downloading" step#58435
Merged
Conversation
bennetbo
approved these changes
Jun 3, 2026
TomPlanche
pushed a commit
to TomPlanche/zed
that referenced
this pull request
Jun 8, 2026
…#58435) Very often, I'd wake up, to which point there's a new Nightly release out, and the update button would be stuck in the "Downloading..." step. It'd only immediately change its state to "Restart" once I quit the app and re-open it again. Turns out we were just missing a cx.notify in the callback to trigger a re-render. Release Notes: - Fixed a bug where the update version button would be stuck in the "Downloading..." step.
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Very often, I'd wake up, to which point there's a new Nightly release out, and the update button would be stuck in the "Downloading..." step. It'd only immediately change its state to "Restart" once I quit the app and re-open it again. Turns out we were just missing a cx.notify in the callback to trigger a re-render.
Release Notes: