Allow Prettier to read the .editorconfig files of the project when formatting from within Zed#59149
Merged
ChristopherBiscardi merged 1 commit intoJun 13, 2026
Conversation
…rmatting from within zed.
Prettier's API requires passing the `{ editorconfig: true }` option to read .editorconfig files. The prettier CLI uses this option by default when running but the API does not.
Fixes zed-industries#10828
ChristopherBiscardi
approved these changes
Jun 13, 2026
ChristopherBiscardi
left a comment
Contributor
There was a problem hiding this comment.
seems reasonable, thanks!
Merged
via the queue into
zed-industries:main
with commit Jun 13, 2026
8589cbb
78 of 80 checks passed
|
Thank you so much ! |
This was referenced Jun 18, 2026
Closed
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
allow Prettier to read the .editorconfig files of the project when formatting from within zed.
Prettier's API requires passing the
{ editorconfig: true }option to read .editorconfig files. The prettier CLI uses this option by default when running but the API does not.API Option for this: https://prettier.io/docs/api#prettierresolveconfigfileurlorpath--options
Code where the CLI of prettier defaults this to true to show this option aligns with Prettier's defaults.
Self-Review Checklist:
Closes #10828
Release Notes: