Skip to content

Fix navigating to Collab URLs not working when not connected#59652

Merged
probably-neb merged 1 commit into
mainfrom
push-zlmwxmqsvpvx
Jun 25, 2026
Merged

Fix navigating to Collab URLs not working when not connected#59652
probably-neb merged 1 commit into
mainfrom
push-zlmwxmqsvpvx

Conversation

@probably-neb

@probably-neb probably-neb commented Jun 21, 2026

Copy link
Copy Markdown
Collaborator

Objective

  • Fix collab channel links opened from URL actions or the CLI when Zed is signed in but not currently connected to the collab server.

Solution

  • Connect to collab before handling channel joins or channel notes links.
  • Keep downstream errors visible if connecting or opening still fails.

Self-Review Checklist:

  • I've reviewed my own diff for quality, security, and reliability
  • Unsafe blocks (if any) have justifying comments
  • The content adheres to Zed's UI standards (UX/UI and icon guidelines)
  • Tests cover the new/changed behavior
  • Performance impact has been considered and is acceptable

Release Notes:

  • Fixed opening collab links when Zed is not already connected to the collaboration server.

@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jun 21, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Jun 21, 2026
@maxdeviant maxdeviant changed the title fix navigating to collab urls not working when not connected Fix navigating to Collab URLs not working when not connected Jun 21, 2026
@probably-neb probably-neb added this pull request to the merge queue Jun 25, 2026
Merged via the queue into main with commit f36a008 Jun 25, 2026
59 of 61 checks passed
@probably-neb probably-neb deleted the push-zlmwxmqsvpvx branch June 25, 2026 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants