Skip to content

Fix code lens not being resolved in remote workflows#59999

Merged
SomeoneToIgnore merged 2 commits into
mainfrom
kb/resolve-code-actions-remote
Jun 28, 2026
Merged

Fix code lens not being resolved in remote workflows#59999
SomeoneToIgnore merged 2 commits into
mainfrom
kb/resolve-code-actions-remote

Conversation

@SomeoneToIgnore

@SomeoneToIgnore SomeoneToIgnore commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Follow-up to #54100
Closes #59122

Original PR overlooked that the resolve was not handled from the remote hosts at all...
Also, fixes the re-fetch of code lens not taking new language servers into account: before, it exit early whilst now it actually re-fetches the lens for the new servers.

Before:

before

After:

after

Release Notes:

  • Fixed code lens not being resolved in remote workflows

@SomeoneToIgnore SomeoneToIgnore requested a review from Veykril June 27, 2026 10:23
@cla-bot cla-bot Bot added the cla-signed The user has signed the Contributor License Agreement label Jun 27, 2026
@zed-community-bot zed-community-bot Bot added the staff Pull requests authored by a current member of Zed staff label Jun 27, 2026
@SomeoneToIgnore SomeoneToIgnore changed the title Kb/resolve code actions remote Resolve code actions on remote Jun 27, 2026
@SomeoneToIgnore SomeoneToIgnore changed the title Resolve code actions on remote Fix code lens not being resolved in remote workflows Jun 27, 2026
@SomeoneToIgnore

Copy link
Copy Markdown
Contributor Author

Note that on the "after" screenshot we have "duplicate" lens showing different numbers: this is a tough problem as vtsls sends us this data and expects its extension(?) to alter certain texts (those are not in the LSP data).

image

Not sure how to do that yet without a custom extension and data introspection, hence ignoring this for now in the generic code.

@SomeoneToIgnore SomeoneToIgnore force-pushed the kb/resolve-code-actions-remote branch from 3aac98c to 8c320c1 Compare June 27, 2026 10:25
@Veykril Veykril added this pull request to the merge queue Jun 28, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 28, 2026
@SomeoneToIgnore SomeoneToIgnore added this pull request to the merge queue Jun 28, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 28, 2026
@SomeoneToIgnore SomeoneToIgnore force-pushed the kb/resolve-code-actions-remote branch from 8c320c1 to 3f90bf8 Compare June 28, 2026 14:34
@SomeoneToIgnore SomeoneToIgnore added this pull request to the merge queue Jun 28, 2026
Merged via the queue into main with commit 0deb6c0 Jun 28, 2026
34 checks passed
@SomeoneToIgnore SomeoneToIgnore deleted the kb/resolve-code-actions-remote branch June 28, 2026 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The user has signed the Contributor License Agreement staff Pull requests authored by a current member of Zed staff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Code lens renders blank lines on remote (SSH) projects (codeLens/resolve unsupported remotely)

2 participants