Skip to content

Suggest Reply: synchronize regeneration labels with reply sessions - #1179

Merged
dkotter merged 10 commits into
WordPress:developfrom
himanshupathak95:fix/suggest-reply-regeneration-label
Oct 14, 2026
Merged

dkotter merged 10 commits into
WordPress:developfrom
himanshupathak95:fix/suggest-reply-regeneration-label

Conversation

@himanshupathak95

@himanshupathak95 himanshupathak95 commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

What?

Show Regenerate Reply after a successful, non-empty AI suggestion. Reset the button to Suggest Reply when the reply form is closed or reopened.

Why?

The button still said “Suggest Reply” after generating a draft, even though clicking it again replaces that draft.

How?

Reuse the existing form lock and observer to update the label. Track whether a suggestion has been inserted, and reset that state when WordPress moves the shared form.

Use of AI Tools

AI assistance: Yes
Tool(s): Codex (Sol 6.1)
Used for: Investigation, benchmarking, and drafting the PR description. The implementation review, testing, and verification are done manually.

Testing Instructions

  1. Enable Suggest Reply in Settings → AI. Open a normal reply in Comments and check that the button says Suggest Reply.
  2. Generate a suggestion. Check Generating… → Regenerate Reply. Edit the draft, change tone, and regenerate; the suggestion should replace the draft.
  3. Cancel and reopen, switch comments, or submit and start another reply. Check that the label resets. Quick Edit should hide the AI controls.
  4. Start a suggestion, switch comments, then return before it finishes. Check that the form locks again, accepts its pending suggestion, and shows Regenerate Reply.
  5. Repeat in Dashboard → Activity. Empty or failed first attempts should keep Suggest Reply.

Screenshots or screencast

Before

Screen.Recording.2026-10-14.at.19.44.12.mov

After

Screen.Recording.2026-10-14.at.19.26.33.mov

Changelog Entry

Fixed - Show “Regenerate Reply” after generating a reply suggestion and reset the label for new reply forms.

Open WordPress Playground Preview

@himanshupathak95
himanshupathak95 force-pushed the fix/suggest-reply-regeneration-label branch from 101621c to e901cd9 Compare October 14, 2026 13:40
@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.17%. Comparing base (26322c3) to head (70a01e0).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1179   +/-   ##
==========================================
  Coverage      82.17%   82.17%           
  Complexity      3399     3399           
==========================================
  Files            136      136           
  Lines          13187    13187           
==========================================
  Hits           10837    10837           
  Misses          2350     2350           
Flag Coverage Δ
unit 82.17% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@himanshupathak95
himanshupathak95 marked this pull request as ready for review October 14, 2026 14:15
@himanshupathak95
himanshupathak95 requested a review from a team October 14, 2026 14:15
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: himanshupathak95 <abcd95@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@dkotter dkotter added this to the 1.5.0 milestone Oct 14, 2026
@dkotter
dkotter merged commit c04acc7 into WordPress:develop Oct 14, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants