Skip to content

Fix Plugin card UI and thickbox issue - #896

Merged
swissspidy merged 1 commit into
feature/creating-standalone-pluginsfrom
fix/minor-issues
Dec 6, 2023
Merged

Fix Plugin card UI and thickbox issue#896
swissspidy merged 1 commit into
feature/creating-standalone-pluginsfrom
fix/minor-issues

Conversation

@mukeshpanchal27

@mukeshpanchal27 mukeshpanchal27 commented Dec 5, 2023

Copy link
Copy Markdown
Member

Summary

This PR fixed the plugin card UI issue and the auto resize thickbox popup issue.

  • The plugin card is not equal height as per the install plugin screen.

Before
Screenshot 2023-12-05 at 11 09 42 AM

After
Screenshot 2023-12-05 at 11 10 30 AM

  • The popup is not auto resize when the screen is big or small.

Before
Screenshot 2023-12-05 at 11 10 03 AM

After
Screenshot 2023-12-05 at 11 10 51 AM

Relevant technical choices

Checklist

  • PR has either [Focus] or Infrastructure label.
  • PR has a [Type] label.
  • PR has a milestone or the no milestone label.

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature no milestone PRs that do not have a defined milestone for release Creating standalone plugins labels Dec 5, 2023
@mukeshpanchal27 mukeshpanchal27 self-assigned this Dec 5, 2023
@mukeshpanchal27
mukeshpanchal27 marked this pull request as ready for review December 6, 2023 05:58
felixarntz
felixarntz reviewed Dec 6, 2023
View reviewed changes
Comment thread admin/plugins.php Resolved
@swissspidy
swissspidy merged commit dcc1d15 into feature/creating-standalone-plugins Dec 6, 2023
@swissspidy
swissspidy deleted the fix/minor-issues branch December 6, 2023 19:39
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Dec 21, 2023
Closed
34 tasks done
@mukeshpanchal27 mukeshpanchal27 mentioned this pull request Mar 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@swissspidy swissspidy swissspidy approved these changes
@felixarntz felixarntz felixarntz approved these changes
@joemcgill joemcgill Awaiting requested review from joemcgill
@JustinyAhin JustinyAhin Awaiting requested review from JustinyAhin

Assignees

@mukeshpanchal27 mukeshpanchal27

Labels

no milestone PRs that do not have a defined milestone for release [Type] Enhancement A suggestion for improvement of an existing feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mukeshpanchal27 @swissspidy @felixarntz