Repository navigation
Unclear error message: "PHP Code Sniffer is not available. Try running composer install first." #254
Description
Describe the bug
I am seeing this error message on all the plugins I test:
PHP Code Sniffer is not available. Try running composer install first.
It appears to be something missing in the Plugin Check plugin itself, not so much the specific plugin I am checking.
Steps to Reproduce
- Install the Plugin Check plugin (Version 0.2.0)
- Test a plugin
- Notice the warning.
Screenshots, screen recording, code snippet
Environment information
- Plugin Check plugin (Version 0.2.0)
- WP Version 6.3.1
WordPress information
No response
Code of Conduct
- I agree to follow this project's Code of Conduct
Activity
bordoni commentedon Sep 21, 2023
That is a super interesting report, I will check on a fresh new PHP locally to see if I can reproduce. On my current local and some of the InstaWP testing instances I used that wasn't a problem.
bordoni commentedon Sep 21, 2023
Figured out what happened. I will take a look into how to resolve that.
shawn-digitalpoint commentedon Sep 21, 2023
It's caused by
plugin-check/inc/class-phpcs.phpcallingis_executable()as the first part of therun()method.That checks the permissions of the
plugin-check/vendor/squizlabs/php_codesniffer/bin/phpcsfile. That file is a PHP file so it doesn't actually need to have executable permissions when running from the web, but maybe there's other places that it runs via CLI so the check is needed? If that's the case, maybe only do the is_executable() check if PHP_SAPI === 'cli' ?The quick and dirty solution for making it work on the web is to change the permissions of the phpcs file to be executable, but making PHP files executable if there's not an actual reason to do so isn't good security practice.