Skip to content

aiohttp is now a required dependency #31

Closed

Description

@michaelbrewer

Even if you don't use or require aiohttp, powertools now has it as a dependency. So now projects without this already declared will fail

/opt/python/3.7.6/lib/python3.7/site-packages/aws_lambda_powertools/tracing/__init__.py:3: in <module>
    from aws_xray_sdk.ext.aiohttp.client import aws_xray_trace_config as aiohttp_trace_config
/opt/python/3.7.6/lib/python3.7/site-packages/aws_xray_sdk/ext/aiohttp/client.py:4: in <module>
    import aiohttp
E   ModuleNotFoundError: No module named 'aiohttp'

Activity

  1. heitorlessa commented on May 14, 2020

    @heitorlessa
    Contributor
  2. heitorlessa commented on May 14, 2020

    @heitorlessa
    Contributor

    Publishing a fix in a few minutes

  3. michaelbrewer commented on May 14, 2020

    @michaelbrewer
    ContributorAuthor

    Awesome thanks. Great tool.

    FYI when using dependabot I don’t see any changelog coming through, maybe by v1 you can start generating one in the repo :)

  4. heitorlessa commented on May 14, 2020

    @heitorlessa
    Contributor

    Just published 0.9.2 with the bugfix - Wheels took a while to generate this time.

    Ha! I thought it was picking up HISTORY file changes - I'll look into it, and thanks again for the tip ;)

    Let me know if that works for you @michaelbrewer

  5. self-assigned this
    on May 14, 2020
  6. michaelbrewer commented on May 14, 2020

    @michaelbrewer
    ContributorAuthor

    @heitorlessa yes, i think @dependabot is looking for a CHANGELOG.md file.

    I can confirm that the fix is working again.

  7. heitorlessa commented on May 14, 2020

    @heitorlessa
    Contributor
  8. michaelbrewer commented on May 14, 2020

    @michaelbrewer
    ContributorAuthor

    @heitorlessa completely unrelated, but you might want to setup GPG signing for your your commits to github.

  9. heitorlessa commented on May 14, 2020

    @heitorlessa
    Contributor

    In my backlog already :). Done, better sooner than postponing once again

  10. added a commit that references this issue on May 16, 2020
    6407b33
  11. added a commit that references this issue on Jun 17, 2020
    82f4a67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

bugSomething isn't working

Type

No type

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions