Skip to content

Include THIRD-PARTY-LICENSES in PyPI tarball #634

Closed

Description

@BastianZim

Is your feature request related to a problem? Please describe.

Currently, THIRD-PARTY-LICENSES is not included in the PyPI tarball: https://pypi.org/project/aws-lambda-powertools/#files

Describe the solution you'd like

It would be great, if the THIRD-PARTY-LICENSES file is also included.

Describe alternatives you've considered

Additional context

I am the maintainer of the conda-forge feedstock and am currently manually including the file.

Activity

  1. boring-cyborg commented on Aug 21, 2021

    @boring-cyborg

    Thanks for opening your first issue here! We'll come back to you as soon as we can.

  2. BastianZim commented on Aug 21, 2021

    @BastianZim
    ContributorAuthor

    Happy to put in a PR if this is something that's acceptable.

  3. heitorlessa commented on Aug 21, 2021

    @heitorlessa
    Contributor
  4. BastianZim commented on Aug 21, 2021

    @BastianZim
    ContributorAuthor

    Hi Heitor, awesome, have added the PR (At least that's where I think it's included). Thanks!

  5. heitorlessa commented on Aug 21, 2021

    @heitorlessa
    Contributor

    Thanks a lot @BastianZim foe the PR - merged it earlier. I'll ping here once we make a release in the coming weeks - we've got some new enhancements we want to work on first.

    Also, first time I hear about conde feedstock, so thanks a lot for including us :-)

  6. BastianZim commented on Aug 21, 2021

    @BastianZim
    ContributorAuthor

    My pleasure, thanks for merging @heitorlessa! Of course, nothing urgent on my side. I'm following the releases so no ping needed for me, just FYI. :)

    Of course! Let me know if anyone here wants to be a maintainer there as well at some point.

  7. heitorlessa commented on Aug 22, 2021

    @heitorlessa
    Contributor

    Available now in PyPi as 1.20.1 ;)

  8. BastianZim commented on Aug 22, 2021

    @BastianZim
    ContributorAuthor

    Thank you!

  9. BastianZim commented on Aug 22, 2021

    @BastianZim
    ContributorAuthor

    @heitorlessa Would you mind opening the issue again? Unfortunately, the license is still not included: https://pypi.org/project/aws-lambda-powertools/#files
    Not entirely sure why as I thought this is done through the Manifest but I have to admit that I'm not the greatest expert on python packaging so I'll try but am probably the wrong person to investigate this further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions