Skip to content

docs(metrics): fix test references - #5265

Merged
leandrodamascena merged 1 commit into
aws-powertools:developfrom
emmanuel-ferdman:develop
Sep 28, 2024
Merged

leandrodamascena merged 1 commit into
aws-powertools:developfrom
emmanuel-ferdman:develop

Conversation

@emmanuel-ferdman

@emmanuel-ferdman emmanuel-ferdman commented Sep 28, 2024 •

Copy link
Copy Markdown
Contributor

Issue number: #5266

Summary

PR #5160 moved the location of some of the test files. This PR adjusts sources to changes.

Changes

Please provide a summary of what's being changed

User experience

Please share what the user experience looks like before and after this change

Checklist

If your change doesn't seem to apply, please leave them unchecked.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
@emmanuel-ferdman
emmanuel-ferdman requested a review from a team September 28, 2024 07:42
@boring-cyborg boring-cyborg Bot added the documentation Improvements or additions to documentation label Sep 28, 2024
@boring-cyborg

boring-cyborg Bot commented Sep 28, 2024

Copy link
Copy Markdown

Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need.
In the meantime, check out the #python channel on our Powertools for AWS Lambda Discord: Invite link

@pull-request-size pull-request-size Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 28, 2024
@sonarqubecloud

Copy link
Copy Markdown

@leandrodamascena leandrodamascena linked an issue Sep 28, 2024 that may be closed by this pull request
1 task done

@leandrodamascena leandrodamascena left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @emmanuel-ferdman, super nice catch! Thanks for fixing this, we completely missed that.

APPROVED!

@leandrodamascena
leandrodamascena merged commit 5665d43 into aws-powertools:develop Sep 28, 2024
@boring-cyborg

boring-cyborg Bot commented Sep 28, 2024

Copy link
Copy Markdown

Awesome work, congrats on your first merged pull request and thank you for helping improve everyone's experience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Docs: fix test references in Metrics utility

2 participants