Skip to content

Docker manifest fails for registries/users where JWT action "*" is restricted (e.g. gitlab) #1010

Closed

Description

@mschrupp

Hi everyone,

playing around with docker manifest on gitlab gives me some issues due to a bug(?) in the docker CLI.

When trying to do a docker manifest push, it fails because gitlab allows * actions only for site admins.

Now I wonder whether the action * for those commands is intentional -
shouldn't it be push and/or pull (at least that's how I understand the docs)

I think (not really sure) I tracked this problem down to the line linked below:

tokenHandler := auth.NewTokenHandler(authTransport, creds, repoName, "*")

The * action hardcoded in the last argument of the function call.

If the * action is required/intentional, I will argue in the corresponding gitlab bug instead (since that means their permission model doesn't work).

Thanks for any input on that issue.

Activity

  1. vdemeester commented on Apr 24, 2018

    @vdemeester
    Collaborator
  2. clnperez commented on Apr 24, 2018

    @clnperez
    Contributor

    Thanks @vdemeester for the tag. I'll take a look.

  3. added a commit that references this issue on Apr 24, 2018
  4. added a commit that references this issue on May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions