Skip to content

GET or POST on preview #34

Open
Open

Description

@sebsel

I found two implementations that do not follow spec, and use GET instead of POST on the Preview action. These are also the only implementation that use the Preview action I could find.

Activity

  1. jackjamieson2 commented on Dec 6, 2018

    @jackjamieson2

    Thanks for raising this question.

    Yarns Microsub Server will accept either GET or POST for preview - https://github.com/jackjamieson2/yarns-microsub-server/blob/master/includes/class-yarns-microsub-endpoint.php#L217

    I think Preview, and Search for that matter, make sense as GET requests

  2. swentel commented on Feb 13, 2019

    @swentel

    The Drupal module now supports preview on POST and GET - same for search.
    I agree with @jackjamieson2 that GET seems more logical.

    Next up - search and preview from Indigenous for Android. I'll be sending a GET request there as I know a lot of people are using aperture.

  3. aaronpk commented on Feb 13, 2019

    @aaronpk
    Member

    I think my reasoning for requiring POST is that, unlike most read operations, this one will actually cause the server to go do work to fetch the URL and such. It felt like it would be more dangerous to allow that to happen on GETs, which may be easily triggered by CSRF and such, so requiring it be a POST is more explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions