Skip to content

Also show name for conda environments created in the workspace #21770

Closed

Description

I have two workspace conda environments namely .conda and .condaTesting as well as a number of virtual environments named .venv, etc..

As you can see from the image, the names of the workspace level conda enviornments are wrong.
As a result its very confusing to tell what conda env has been selected.
Screenshot 2023-08-06 at 19 20 48

Activity

  1. myabanky commented on Aug 7, 2023

    @myabanky
  2. DonJayamanne commented on Aug 7, 2023

    @DonJayamanne
    Author
  3. changed the title [-]Incorrect display name for workspace conda environment, always displays the name as `conda`[/-] [+]Also show name for conda environments created in the workspace[/+] on Aug 9, 2023
  4. added
    debtCode quality issues
    area-environmentsFeatures relating to handling interpreter environments
    needs PRReady to be worked on
    and removed
    bugIssue identified by VS Code Team member as probable bug
    triage-neededNeeds assignment to the proper sub-team
    on Aug 9, 2023
  5. removed their assignment
    on Aug 9, 2023
  6. karrtikr commented on Aug 9, 2023

    @karrtikr

    At least when displaying it, we can show the name. Even though while activating or using the environments, these have no names.

    Marking as a good first issue, code to be modified here:

    function buildEnvDisplayString(env: PythonEnvInfo, getAllDetails = false): string {

    if env.searchLocation exists and it is a conda environment, create display name using env name.

  7. 11 remaining items

  8. PopoDev commented on Dec 27, 2023

    @PopoDev

    Hi Kartik Raj (@karrtikr), I'd like to give it a try!

    If I understood correctly conda environments don't have an env.name. Can we create the display name using the basename of env.location ?

  9. added a commit that references this issue on Jan 19, 2024
    1eaf5a3
  10. karrtikr commented on Jan 19, 2024

    @karrtikr

    Fix should be out in the pre-release version of the extension in a day, use the following to try it out:

    image

  11. added this to the milestone on Jan 19, 2024
  12. PopoDev commented on Jan 20, 2024

    @PopoDev

    The fix seems to work as expected. It shows the names of the workspace level conda environments, e.g .conda, .condaTesting and .condaWorkspace.

    validate-show-conda-env-names

  13. PopoDev commented on Jan 20, 2024

    @PopoDev

    Also the new Create Environment in Select Interpreter looks neat !

  14. jrieken commented on Jan 25, 2024

    @jrieken

    Adding verified based on #21770 (comment)

  15. locked as resolved and limited conversation to collaborators on Mar 4, 2024
  16. added 2 commits that reference this issue on Mar 28, 2024
    3e611b8
    9b4975a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

area-environmentsFeatures relating to handling interpreter environmentsfeature-requestRequest for new features or functionalitygood first issueverification-neededVerification of issue is requestedverifiedVerification succeeded

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions