Repository navigation
Add button to clear list and refresh in interpreters quickpick - #19628
Merged
Merged
Conversation
added 9 commits
August 2, 2022 13:04
Kartik Raj (karrtikr)
added
the
feature-request
| input.buttons = this.steps.length > 1 ? [QuickInputButtons.Back] : []; | ||
| if (customButtonSetup) { | ||
| input.buttons = [...input.buttons, customButtonSetup.button]; | ||
| if (customButtonSetups) { |
There was a problem hiding this comment.
If it is an array you should evaluate if it's empty, otherwise it will always enter here.
Author
There was a problem hiding this comment.
We want to always enter here, can you explain how evaluating if an array is empty helpful?
Author
There was a problem hiding this comment.
Let me know if I missed something and I can fix it in the next PR.
Paula (paulacamargo25)
approved these changes
Aug 4, 2022
Paula (paulacamargo25)
left a comment
Paula (paulacamargo25)
left a comment
There was a problem hiding this comment.
Looks good for me, i just put a single comment.
…o addhardrefresh
Wes McKinney (wesm)
pushed a commit
to posit-dev/positron
that referenced
this pull request
Mar 28, 2024
…soft/vscode-python#19628) * Change refresh icon when interpreter list is refreshing * Add tests * Minor tweaks * Fix situation if dialog box is cancelled * Fix tests * Improve ignoreErrors() typing * Update to not use custom svg, instead use built VSCode icon * Add vscode mock * Add button to clear interpreters list and refresh in quickpick
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19621
Based on #19611, please only review the last commit: fe5d492.
After consulting with Luciana, added another button to support hard refreshing, which clears the cache before refreshing.