Repository navigation
Implement PEP 488 #67919
Description
| BPO | 23731 |
|---|---|
| Nosy | @warsaw, @brettcannon, @gpshead, @pfmoore, @tjguk, @ericsnowcurrently, @zware, @zooba |
| Files |
Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.
Show more details
GitHub fields:
assignee = 'https://github.com/brettcannon'
closed_at = <Date 2015-04-13.18:26:04.370>
created_at = <Date 2015-03-21.13:33:50.984>
labels = ['interpreter-core', 'type-feature', 'release-blocker']
title = 'Implement PEP 488'
updated_at = <Date 2015-05-13.05:28:01.630>
user = 'https://github.com/brettcannon'bugs.python.org fields:
activity = <Date 2015-05-13.05:28:01.630>
actor = 'python-dev'
assignee = 'brett.cannon'
closed = True
closed_date = <Date 2015-04-13.18:26:04.370>
closer = 'brett.cannon'
components = ['Interpreter Core']
creation = <Date 2015-03-21.13:33:50.984>
creator = 'brett.cannon'
dependencies = []
files = ['38786', '38869']
hgrepos = ['303']
issue_num = 23731
keywords = ['patch']
message_count = 10.0
messages = ['238799', '238908', '239824', '239835', '239839', '239876', '240327', '240696', '240700', '243039']
nosy_count = 9.0
nosy_names = ['barry', 'brett.cannon', 'gregory.p.smith', 'paul.moore', 'tim.golden', 'python-dev', 'eric.snow', 'zach.ware', 'steve.dower']
pr_nums = []
priority = 'release blocker'
resolution = 'fixed'
stage = 'resolved'
status = 'closed'
superseder = None
type = 'enhancement'
url = 'https://bugs.python.org/issue23731'
versions = ['Python 3.5']
Activity
brettcannon commentedon Mar 21, 2015
https://www.python.org/dev/peps/pep-0488/
brettcannon commentedon Mar 22, 2015
Will probably want to see http://bugs.python.org/issue17232 resolved as part of this as well.
brettcannon commentedon Apr 1, 2015
Here is a patch that implements PEP-488 **except** for Windows installer stuff. I don't think the Windows changes need to block this patch going in, but I will need someone on Windows to help fix up PC/, PCbuild/, Tools/msi, Lib/distutils/command/bdist_msi.py, and Lib/distutils/command/bdist_wininst.py (if you just search for [pyo] you will find what needs an update).
Otherwise if someone wants to give the patch a review you can feel free, else I will commit it at PyCon (do be aware that if you run tests under -O and -OO there are several failures that have nothing to do with this patch).
zooba commentedon Apr 1, 2015
I don't actually see any essential changes. The bdist_wininst and bdist_msi changes are just for usage help, and presumably they'll go from "do not compile .py to .pyo (optimized)" to "do not compile .py to optimized .pyc".
I'd prefer to leave the .pyo file association in the installer, since it will affect previous installations.
The only change I see in PC/ is PC/getpathp.c, which is just removing a condition on "o" vs "c", and I don't see anything in PCBuild/ that really needs fixing. (Removing the cleanup code is unnecessary and leaving it in may help make sure the buildbots clean up any old .pyo files after we stop creating them.)
pfmoore commentedon Apr 1, 2015
A few minor review comments. Nothing substantial, tbh. Looks good.
ericsnowcurrently commentedon Apr 2, 2015
Thanks for doing this, Brett. It's so simple a change yet such a great one. :)
ericsnowcurrently commentedon Apr 9, 2015
LGTM
python-dev commentedon Apr 13, 2015
New changeset a86d630555bd by Brett Cannon in branch 'default':
Issue bpo-23731: Implement PEP-488.
https://hg.python.org/cpython/rev/a86d630555bd
brettcannon commentedon Apr 13, 2015
Thanks to Paul and Eric for the review and everyone who provided input!
python-dev commentedon May 13, 2015
New changeset bbdbc4399b52 by Zachary Ware in branch 'default':
Issue bpo-23731: Fix tracemalloc test on Windows.
https://hg.python.org/cpython/rev/bbdbc4399b52