Repository navigation
docs: document prod vs dev behavior difference in componentDidCatch - #2168
Conversation
|
Deploy preview for reactjs ready! Built with commit 774f5d8 |
|
What's the process to get this PR merged? |
|
Is there any way to get this PR merged? Do you accept contributions? |
|
I was confused by this, would be nice to see this merged! |
WNemencha
left a comment
WNemencha
left a comment
There was a problem hiding this comment.
I approve these changes (thx Twitter lol)
|
Could we move this documentation merge forward or what is blocking here? Until then anyone integrating third-party logging will be wasting time wondering why their ErrorBoundary implementations are silently failing in development due to React's development 'trick' as described here |
|
Wow, it's been over a year. All checks have passed but this PR still remains stagnant. 😞 |
eps1lon
left a comment
eps1lon
left a comment
There was a problem hiding this comment.
Re-discovered it since it came up on twitter (again). Much better to link to official documentation than comments spread over GitHub issues.
Documentation can be improved with a rationale or documentation of common error handling patterns. But having a documentation for the "what" is already a big step, thanks!
|
Glad to see this is now documented. As a next step, I would like to suggest that React should not re-throw errors which are caught by boundaries (in development)—it's very surprising behaviour. I filed an issue: react/react#19613 |
| } | ||
| ``` | ||
|
|
||
| Production and development builds of React slightly differ in the way `componentDidCatch()` handles errors. |
There was a problem hiding this comment.
wasted 2 hours trying to debug this... 💀
just realised it was all working fine
|
I think this needs to be updated in light of the changes to error handling in React 19. The current docs suggest errors bubble up to |
This PR aims to document the
componentDidCatch()behavior described by @gaearon in this comment.I may use some help with the wording of this new paragraph.