You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Inconsistency with os.environ and str/unicode in Python 2 #176
I think that it's probably not worth fixing given Python 2's upcoming end of life, but I'm pointing this out here because this might justify turning off some Mypy type warnings for Python 2.
this might justify turning off some Mypy type warnings for Python 2
Actually, that's a terrible idea! I just found a bug with Unicode and Python 2 hidden behind a # type: ignore. To be more precise, this bug is fairly recent (version 0.10.0) whereas the str/unicode inconsistency pointed out in this issue has existed for a long time (at least since version 0.9.0). I'll open a separate issue.
Activity
bbc2 commentedon May 4, 2019
Apparently, this was fixed on Windows thanks to #101, but that fix probably accidentally went away with later MRs.
bbc2 commentedon May 4, 2019
Actually, that's a terrible idea! I just found a bug with Unicode and Python 2 hidden behind a
# type: ignore. To be more precise, this bug is fairly recent (version 0.10.0) whereas the str/unicode inconsistency pointed out in this issue has existed for a long time (at least since version 0.9.0). I'll open a separate issue.theskumar commentedon May 12, 2019
Released the fix in v0.10.2, thanks! 🎉