Skip to content

bpo-40334: Allow to run make regen-pegen without distutils#19684

Merged
pablogsal merged 1 commit intopython:masterfrom
pablogsal:regen_pegen
Apr 23, 2020
Merged

bpo-40334: Allow to run make regen-pegen without distutils#19684
pablogsal merged 1 commit intopython:masterfrom
pablogsal:regen_pegen

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Apr 23, 2020 •
edited by bedevere-bot
Loading

@pablogsal
Copy link
Member Author

pablogsal commented Apr 23, 2020

CC: @lysnikolaou

@pablogsal
Copy link
Member Author

pablogsal commented Apr 23, 2020

Sadly, we cannot support < Python3.8 because the walrus operator is used in the generated meta-parser :(

@serhiy-storchaka Would you like to skip the pegen regeneration if PYTHON_FOR_REGEN is not at least 3.8? Or maybe crash with a better error message?

@lysnikolaou
Copy link
Member

lysnikolaou commented Apr 23, 2020

LG.

@pablogsal
Copy link
Member Author

pablogsal commented Apr 23, 2020

There isn't much that we can do without a considerable redesign to allow running this with something lower than Python3.8 as the generated parser for Python heavily uses the := operator so I will land this so the rest of the reported problems are fixed and a clear error message is emitted in case you run with something lower than 3.8.

@pablogsal pablogsal merged commit 50f28de into python:master Apr 23, 2020
@pablogsal pablogsal deleted the regen_pegen branch April 23, 2020 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pablogsal @lysnikolaou @the-knights-who-say-ni @bedevere-bot