Skip to content

bpo-40334: Use old compiler when compile mode is func_type#19692

Merged
gvanrossum merged 1 commit intomasterfrom
fix-func-type
Apr 23, 2020
Merged

bpo-40334: Use old compiler when compile mode is func_type#19692
gvanrossum merged 1 commit intomasterfrom
fix-func-type

Conversation

@gvanrossum
Copy link
Member

@gvanrossum gvanrossum commented Apr 23, 2020

This is invoked by mypy, using ast.parse(source, "<func_type>", "func_type"). Since the new grammar doesn't yet support the func_type_input start symbol we must use the old compiler in this case to prevent a crash.

https://bugs.python.org/issue40334

Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gvanrossum gvanrossum merged commit bc28805 into master Apr 23, 2020
@gvanrossum gvanrossum deleted the fix-func-type branch April 23, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants