bpo-40334: Improve column offsets for thrown syntax errors by Pegen#19782
Merged
pablogsal merged 4 commits intopython:masterfrom May 1, 2020
Merged
bpo-40334: Improve column offsets for thrown syntax errors by Pegen#19782pablogsal merged 4 commits intopython:masterfrom
pablogsal merged 4 commits intopython:masterfrom
Conversation
lysnikolaou
reviewed
Apr 29, 2020
lysnikolaou
reviewed
Apr 29, 2020
Member
lysnikolaou
left a comment
There was a problem hiding this comment.
Thanks @isidentical for spending time on this! It's a really nice improvement.
lysnikolaou
approved these changes
Apr 29, 2020
Member
|
@isidentical there's a merge conflict -- you need to merge master and run |
gvanrossum
approved these changes
May 1, 2020
Member
Author
|
@gvanrossum resolved |
Member
Best way of fixing a bug! 🎉 |
Member
|
The travis target is stucked, closing and reopening to re-trigger the CI |
Member
|
Hummm, there is a bunch of warnings now after the last rebasing: @isidentical could you take a look? Seems that we are passing the error message incorrectly with this PR |
Member
Author
Yup, this PR changes signature of _PyPegen_raise_error. I missed that usage when I rebased. Now, it should be fixed. |
This was referenced May 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been trying to figure out a good way to handle
ast.cerrors, but no luck so far. I've splitted them to their own test and fixed remaining offset errors to ensure full compatibility with the old parser.https://bugs.python.org/issue40334