Skip to content

bpo-40334: Support suppressing of multiple optional variables in Pegen#20367

Merged
pablogsal merged 1 commit intopython:masterfrom
isidentical:bpo-40334-opt-var-multiple
May 24, 2020
Merged

bpo-40334: Support suppressing of multiple optional variables in Pegen#20367
pablogsal merged 1 commit intopython:masterfrom
isidentical:bpo-40334-opt-var-multiple

Conversation

@isidentical
Copy link
Member

@isidentical isidentical commented May 24, 2020 •
edited
Loading

C generator would produce _opt_var_1, _opt_var_2 etc. for multiple optional variables in the same context. This patch makes the C generator to support multiple optional variables.

https://bugs.python.org/issue40334

@isidentical isidentical requested a review from pablogsal as a code owner May 24, 2020 21:53
@pablogsal
Copy link
Member

pablogsal commented May 24, 2020

The title suggest that multiple optional variables do not work, but that's not true isn't it? What happens is that we are not suppressing compiler warnings, no? If I am correct, is ok with merging this without a test

@isidentical isidentical changed the title bpo-40334: Support generation of multiple optional variables in pegen bpo-40334: Support suppressing of multiple optional variables in Pegen May 24, 2020
@pablogsal pablogsal merged commit cba5031 into python:master May 24, 2020
@miss-islington
Copy link
Contributor

miss-islington commented May 24, 2020

Thanks @isidentical for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented May 24, 2020

GH-20368 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request May 24, 2020
@miss-islington @isidentical
bpo-40334: Support suppressing of multiple optional variables in Pegen (
82c274e 
GH-20367)

(cherry picked from commit cba5031)

Co-authored-by: Batuhan Taskaya <batuhanosmantaskaya@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@lysnikolaou lysnikolaou lysnikolaou approved these changes

@pablogsal pablogsal Awaiting requested review from pablogsal

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@isidentical @pablogsal @miss-islington @bedevere-bot @gvanrossum @lysnikolaou @the-knights-who-say-ni