SC: Support long sync call names #1701
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
reviewed
Jul 9, 2025
Contributor
heifner
left a comment
heifner
left a comment
There was a problem hiding this comment.
Seems ok for now assuming it is temporary until it is replaced by interfaces.
Otherwise would like to see eosio::name used instead of uint64_t.
heifner
approved these changes
Jul 9, 2025
spoonincode
reviewed
Jul 10, 2025
| static const std::string expected = R"=====(Test BEGIN ================== | ||
| Before calling sync call basictest | ||
| [caller->(callee,basictest)]: CALL BEGIN ====== | ||
| [caller->(callee,249882312350186951)]: CALL BEGIN ====== |
Contributor
There was a problem hiding this comment.
This is okay for now? You don't want to go ahead and do the id->name mapping?
Contributor
Author
There was a problem hiding this comment.
Yes, Areg said it is OK for now, as looking up the mapping will require ABI, and this will be changed in dev2 when the sync call names and event IDs are using the same new mechanism.
spoonincode
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Spring side to support sync call long names.
Depends on CDT AntelopeIO/cdt#362
Resolves #1581