Skip to content

Fix commit link in ci slack message #9221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sliptype merged 1 commit into from
Jul 22, 2024
Merged

Fix commit link in ci slack message #9221

sliptype merged 1 commit into from
Jul 22, 2024

Conversation

@sliptype
Copy link
Contributor

@sliptype sliptype commented Jul 22, 2024

Description

Does this break another case I'm not aware of?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

@sliptype sliptype requested a review from rickyrombo July 22, 2024 15:52
@changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2024

⚠️ No Changeset found

Latest commit: 30484ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

rickyrombo
rickyrombo approved these changes Jul 22, 2024
View reviewed changes
Copy link
Contributor

@rickyrombo rickyrombo left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope I don't think so, copy paste bug I'm pretty sure! The place to check would be the protocol daily deploy msgs but iirc I don't think this is reused

Though I think if we wanted to be clever we could derive the gh link from the circle env

This seems good though - thanks for fixing!!!

@sliptype sliptype merged commit 1e08bbc into main Jul 22, 2024
@sliptype sliptype deleted the sk-fix-commit-link branch July 22, 2024 15:56
schottra added a commit that referenced this pull request Jul 22, 2024
@schottra
Merge remote-tracking branch 'origin/main' into pay-2917-user-endpoints
b7fdd24 
* origin/main: (64 commits)
  [C-4837] Fix links for the searching by electronic subgenre from track page (#9225)
  [QA-1452] Fix edit playlist issues (#9226)
  [C-4848] Remove search v2 responsiveness and fix padding on mobile web (#9224)
  Remove fingerprint webhook (#9052)
  Discovery: fix bad musical keys (#9200)
  [C-4842] Fix tag press on mobile for search v2 (#9223)
  [PAY-3192] Fix two issues with playlist_contents and added_timestamps (#9217)
  [C-4829] Fix mobile web drawer overflow (#9220)
  [QA-1458] Fix artwork image loading (#9219)
  Fix commit link in ci slack message (#9221)
  Update dapp-store build artifacts
  [QA-1455] Fix disappearing playlists in sidebar (#9216)
  [C-4643] Feature flag scheduled premium album release (#9215)
  Audius Protocol v0.6.152
  [C-4676] Filter out deleted user content from search (#9208)
  Bump mobile versions to 107 (#9218)
  image skipCache goes all the way (#9212)
  [PAY-3177][PAY-3185] Fix mobile track publish button (#9213)
  Audius Client (Web and Mobile) v1.5.91
  [PAY-3174][PAY-3179] Do not show confirmation modals for edit access during upload (#9204)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickyrombo rickyrombo rickyrombo approved these changes

Assignees

No one assigned

Labels

size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sliptype @rickyrombo