[PAY-3192] Fix two issues with playlist_contents and added_timestamps #9217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sliptype
approved these changes
Jul 22, 2024
Contributor
sliptype
left a comment
sliptype
left a comment
There was a problem hiding this comment.
Great find! I think this is good for now, we can discuss more about the fate of added_timestamps
schottra
added a commit
that referenced
this pull request
Jul 22, 2024
* origin/main: (64 commits) [C-4837] Fix links for the searching by electronic subgenre from track page (#9225) [QA-1452] Fix edit playlist issues (#9226) [C-4848] Remove search v2 responsiveness and fix padding on mobile web (#9224) Remove fingerprint webhook (#9052) Discovery: fix bad musical keys (#9200) [C-4842] Fix tag press on mobile for search v2 (#9223) [PAY-3192] Fix two issues with playlist_contents and added_timestamps (#9217) [C-4829] Fix mobile web drawer overflow (#9220) [QA-1458] Fix artwork image loading (#9219) Fix commit link in ci slack message (#9221) Update dapp-store build artifacts [QA-1455] Fix disappearing playlists in sidebar (#9216) [C-4643] Feature flag scheduled premium album release (#9215) Audius Protocol v0.6.152 [C-4676] Filter out deleted user content from search (#9208) Bump mobile versions to 107 (#9218) image skipCache goes all the way (#9212) [PAY-3177][PAY-3185] Fix mobile track publish button (#9213) Audius Client (Web and Mobile) v1.5.91 [PAY-3174][PAY-3179] Do not show confirmation modals for edit access during upload (#9204) ...
audius-infra
pushed a commit
that referenced
this pull request
Jul 23, 2024
[59fddcf] mutex around crc32 hasher (#9231) Steve Perkins [64ff2d9] Improve logging spam situation (#9238) Raymond Jacobson [11f5325] [PAY-3176][PAY-3188][PAY-3193] Include premium tracks in DN playlists for owner (#9234) Saliou Diallo [bf1964c] [QA-1449] [C-4808] Reassign playlist_contents in get_bulk_playlists (#9232) Sebastian Klingler [8d658e5] Remove fingerprint webhook (#9052) Danny [e8504bd] Discovery: fix bad musical keys (#9200) Michelle Brier [8abb4a5] [PAY-3192] Fix two issues with playlist_contents and added_timestamps (#9217) Randy Schott
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
playlist_modelexpects that the type ofplaylist_contentswill be the same shape as that ofadded_timestamps. This is due to the change in [C-2735] Add updatePlaylist and publishPlaylist to sdk #5570 where we replaceplaylist_contentswithadded_timestampsas a client/SDK convenience. But we only do that in theplaylistsendpoints./repostsis missing this behavior so the marshaller malfunctions on the playlist items from that endpoint.added_timestampsincorrectly returns the entire playlist as a response ifplaylist_contentsis empty. I think this was originally meant as a "decorator" method that would modify the contents in place and return the modified object, then converted to a utility that computes the value of a property and returns it. I updated the name of the function and fixed the early return to be an empty list.How Has This Been Tested?
Tested locally against local stack.