-
Notifications
You must be signed in to change notification settings - Fork 126
mutex around crc32 hasher #9231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| continue | ||
| } | ||
|
|
||
| // invalid url |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this feels a bit like a bandaid, do we know the root cause yet?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it is... I think the mutex is the real fix. But there are 3 different "SP" providers (https://api.audius.co/, the graph, eth gateway)... and I wasn't sure if one of them might possibly give bad data somehow?
So trying to cover that basis for the quick fix here.
|
|
||
| // after migration complete, just call `rank` | ||
|
|
||
| rh.mu.Lock() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the theory here that this is getting interrupted somehow? that's crazy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MY GUY!
[59fddcf] mutex around crc32 hasher (#9231) Steve Perkins [64ff2d9] Improve logging spam situation (#9238) Raymond Jacobson [11f5325] [PAY-3176][PAY-3188][PAY-3193] Include premium tracks in DN playlists for owner (#9234) Saliou Diallo [bf1964c] [QA-1449] [C-4808] Reassign playlist_contents in get_bulk_playlists (#9232) Sebastian Klingler [8d658e5] Remove fingerprint webhook (#9052) Danny [e8504bd] Discovery: fix bad musical keys (#9200) Michelle Brier [8abb4a5] [PAY-3192] Fix two issues with playlist_contents and added_timestamps (#9217) Randy Schott
* origin/main: Audius Protocol v0.6.153 mutex around crc32 hasher (#9231) Improve logging spam situation (#9238) [C-4792] Disallow Add To Playlist for hidden tracks (#9236) [PAY-3176][PAY-3188][PAY-3193] Include premium tracks in DN playlists for owner (#9234) Remove use_sdk_purchase_track and use_sdk_purchase_album feature flags (#9192) Add ability to change playlist/track visibility w/ audius-cmd (#9094) Remove use_sdk_tips feature flag (and fix indexing check) (#9193) Pin docker-compose-plugin to fix env var issue (#9235) [QA-1449] [C-4808] Reassign playlist_contents in get_bulk_playlists (#9232) [C-4832] Fix missing play counts on track tiles (#9230) [QA-1442] Add offline indicator to collection card (#9227) [QA-1463] Change order of mobile action buttons (#9229)
No description provided.