Skip to content

Conversation

@stereosteve
Copy link
Contributor

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Jul 22, 2024

⚠️ No Changeset found

Latest commit: 318a2f2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

continue
}

// invalid url
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this feels a bit like a bandaid, do we know the root cause yet?

Copy link
Contributor Author

@stereosteve stereosteve Jul 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is... I think the mutex is the real fix. But there are 3 different "SP" providers (https://api.audius.co/, the graph, eth gateway)... and I wasn't sure if one of them might possibly give bad data somehow?

So trying to cover that basis for the quick fix here.


// after migration complete, just call `rank`

rh.mu.Lock()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the theory here that this is getting interrupted somehow? that's crazy

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MY GUY!

@stereosteve stereosteve merged commit 59fddcf into main Jul 23, 2024
@stereosteve stereosteve deleted the rendezvous-mutex branch July 23, 2024 14:12
audius-infra pushed a commit that referenced this pull request Jul 23, 2024
[59fddcf] mutex around crc32 hasher (#9231) Steve Perkins
[64ff2d9] Improve logging spam situation (#9238) Raymond Jacobson
[11f5325] [PAY-3176][PAY-3188][PAY-3193] Include premium tracks in DN playlists for owner (#9234) Saliou Diallo
[bf1964c] [QA-1449] [C-4808] Reassign playlist_contents in get_bulk_playlists (#9232) Sebastian Klingler
[8d658e5] Remove fingerprint webhook (#9052) Danny
[e8504bd] Discovery: fix bad musical keys (#9200) Michelle Brier
[8abb4a5] [PAY-3192] Fix two issues with playlist_contents and added_timestamps (#9217) Randy Schott
schottra added a commit that referenced this pull request Jul 23, 2024
* origin/main:
  Audius Protocol v0.6.153
  mutex around crc32 hasher (#9231)
  Improve logging spam situation (#9238)
  [C-4792] Disallow Add To Playlist for hidden tracks (#9236)
  [PAY-3176][PAY-3188][PAY-3193] Include premium tracks in DN playlists for owner (#9234)
  Remove use_sdk_purchase_track and use_sdk_purchase_album feature flags (#9192)
  Add ability to change playlist/track visibility w/ audius-cmd (#9094)
  Remove use_sdk_tips feature flag (and fix indexing check) (#9193)
  Pin docker-compose-plugin to fix env var issue (#9235)
  [QA-1449] [C-4808] Reassign playlist_contents in get_bulk_playlists (#9232)
  [C-4832] Fix missing play counts on track tiles (#9230)
  [QA-1442] Add offline indicator to collection card (#9227)
  [QA-1463] Change order of mobile action buttons (#9229)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants