[QA-1533] Filter out deactivated users from UserList queries #9596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
raymondjacobson
approved these changes
Aug 30, 2024
| follows | ||
| left outer join aggregate_user on followee_user_id = user_id | ||
| join users on users.user_id = follows.followee_user_id | ||
| left outer join aggregate_user on followee_user_id = aggregate_user.user_id |
Member
There was a problem hiding this comment.
for future reader's sake, i don't believe this left outer is necessary. aggregate user should always exist. but it's probably fine 🤷
audius-infra
pushed a commit
that referenced
this pull request
Sep 2, 2024
[b87f574] Fix Splits Migration: Stage has users w/o indexed user banks (#9604) Marcus Pasell [847c075] [PAY-3319][PAY-3399] Update Discovery to support new purchase transaction details (#9586) Marcus Pasell [74ab87e] [PAY-3388] Add user feed V1 endpoint (#9583) Randy Schott [5c520c1] [QA-1533] Filter out deactivated users from UserList queries (#9596) Reed [c52e0cb] Filter genre metrics endpoint by allowlist (#9591) Randy Schott [0b92de2] Revert "Enabling blocking users from commenting (#9469)" (#9552) Isaac Solo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bug was: if user follows many other users who are deactivated, there's a possibility that the first page of followees would be almost entirely deactivated, which get filtered out on client. This wouldn't be an issue except it also breaks pagination on the client because there's no way to know when the end of the list is reached.
Note that this could be a problem with other modals that use UserList. Maybe need a bigger discussion around how to handle deactivated users, perhaps those follow counts should be omitted from
aggregate_useras well, and all queries should filter them out by default.But this PR fixes the immediate problem.
How Has This Been Tested?
Local stack - created many users who logged-in user follows, checked which ones were getting returned in the first page and set some of those to deactivated, confirmed modal works with pagination.
Screen.Recording.2024-08-30.at.4.11.56.PM.mov