Enabling blocking users from commenting #9469

isaacsolo · 2024-08-15T22:55:12Z

Description

When an artist blocks a user from DMs, it'll also block the user from commenting. The comments from that blocked user will also be hidden.

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Blocked this user from commenting on my track. Confirmed that blocked user is unable to comment and non-blocked user comments still show.

changeset-bot · 2024-08-15T22:55:15Z

⚠️ No Changeset found

Latest commit: c1bb49e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

audius-infra · 2024-08-15T23:07:02Z

Preview this change https://demo.audius.co/is-block-user-comments

DejayJD · 2024-08-16T17:32:36Z

packages/discovery-provider/src/models/users/chat_blocked_users.py

+class ChatBlockedUser(Base, RepresentableMixin):
+    __tablename__ = "chat_blocked_users"
+
+    blocker_user_id = Column(Integer, primary_key=True, nullable=False)
+    blockee_user_id = Column(Integer, primary_key=True, nullable=False, index=True)
+    created_at = Column(DateTime, nullable=False)


Is this a model of the db that comms contributes to?

nice, so then the current way to test blocking a user is just via the DMs screen?

yea but you can also block on a user's profile. I didn't see designs for this yet but maybe i missed it

DejayJD

Nicely done! This honestly came together super quick

DejayJD · 2024-08-16T17:54:26Z

packages/web/src/pages/track-page/components/desktop/TrackPage.tsx

          justifyContent='center'
        >
-          {isCommentingEnabled ? (
+          {isCommentingEnabled && heroTrack?.owner_id ? (


This is fine for now, but making a note for myself that this may interrupt the loading animation; may rework it later.

gitguardian · 2024-08-19T16:40:34Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
13407071	Triggered	Generic High Entropy Secret	`3356875`	comms/Makefile	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

audius-infra · 2024-08-19T17:17:52Z

Preview this change https://demo.audius.co/is-block-user-comments

[b914ade] [PAY-2918] Migrate tracks endpoints to SDK - round 1 (#9474) Randy Schott [b53b774] [PAY-3201] Fix chat blast reactions (#9487) Reed [bfaa536] Enabling blocking users from commenting (#9469) Isaac Solo [5944ced] [PAY-3358] Fire chat message RPCs on blast write (#9476) Reed [d4de8a1] [PAY-3299] Chat blast sender endpoints (#9473) Steve Perkins

[1ba94b8] Reland "[PAY-3357] Migrate Notifications to SDK" (#9539) Marcus Pasell [c33b4e3] Revert "[PAY-3357] Migrate Notifications to SDK" (#9538) Marcus Pasell [b8c360e] [PAY-3357] Migrate Notifications to SDK (#9516) Marcus Pasell [eaef9fd] [QA-1498] Fix long press on DMs (#9533) JD Francis [4bbfeff] [PAY-3373] Purchasers endpoint (#9525) Reed [72ff6a3] [C-4909] Improve track metadata list, fix album backlinks (#9531) Dylan Jeffers [e5248b7] [QA-1515] Remove dismiss on leave from popup (#9527) JD Francis [46305bb] [PAY-2918] Migrate track endpoints to SDK - Round 3 (#9522) Randy Schott [b957a52] Fix challenge api tx confirming (#9526) Isaac Solo [6999b53] [QA-1519] Fix buyer metadata caching (#9512) Isaac Solo [7f17c95] Hook up remixers count to web blast UI (#9523) Reed [75ab270] [PAY-3359] Chat blast thread UI on sender side (#9515) Reed [93e3ac9] Mobile comment fixes (#9507) Sebastian Klingler [c81ed5d] [QA-1499] Fix long usernames overflowing manager mode button (#9519) JD Francis [7763deb] Add react-router dependency (#9520) Isaac Solo [6de56bd] Move trpc to common (#9518) Dylan Jeffers [76d4095] Active styles for web chat blasts (#9517) Reed [3464a2a] Add row and column props to flex (#9505) Dylan Jeffers [e6b1da1] [C-4902] Add harmony checkbox (#9510) Dylan Jeffers [0fcf9e4] [PAY-3361] ChatBlastSelectAudienceScreen (#9502) Andrew Mendelsohn [2566eb8] [PAY-3228] Implement composer unfurl in mobile (#9504) Raymond Jacobson [b5bf00a] [QA-1210] Fix popup scrolling issues (#9508) JD Francis [5349315] Update logic for allowing chat blast sending (#9509) Reed [51391d9] [PAY-3362] Move link resolver to common hook (#9503) Raymond Jacobson [45dc83d] Add feature flag refresh (#9506) Dylan Jeffers [3af4e69] [PAY-2918] Migrate track endpoints to SDK, Round 2 (#9494) Randy Schott [78897c4] [PAY-3355] Address link preview / unfurl QA items (#9492) Raymond Jacobson [c2a9387] [PAY-3366] Fix CTA hidden on small screens (#9499) Andrew Mendelsohn [e6dbb7a] Fix CTA empty states reversed web/mobile (#9498) Andrew Mendelsohn [f3d7825] Remove listenUserId from chat api (#9479) Reed [d55dbb1] [PAY-3360] Chat Blast CTA (mobile) (#9491) Andrew Mendelsohn [adb99e3] Fix challenge claim notification amount (#9485) Isaac Solo [d4518ce] [C- 4926] Add Menu/MenuItem and update Select (#9427) Dylan Jeffers [b914ade] [PAY-2918] Migrate tracks endpoints to SDK - round 1 (#9474) Randy Schott [893ed42] Revamp local solana-test-validator (#9482) Marcus Pasell [7ff4ab0] Separate saga top level error handling (#9458) Raymond Jacobson [06a19e6] Remote config for chat blast tier requirement (#9490) Reed [2b804b2] [PAY-3345] Prevent artist reacting to their own blasts (#9488) Reed [1cc1915] [C-4976] Refactor comment hooks (#9489) Sebastian Klingler [b3a4c77] [QA-1511] Fix space & arrow hotkeys not working (#9486) JD Francis [1342d1f] [C-4823] Mobile comment drawer (#9478) Sebastian Klingler [075d757] [QA-1514] Fix search filter typing (#9484) Sebastian Klingler [bfaa536] Enabling blocking users from commenting (#9469) Isaac Solo [c2d5e85] Bump mobile apps to 111 (#9481) Dylan Jeffers [5944ced] [PAY-3358] Fire chat message RPCs on blast write (#9476) Reed [83c97ed] [C-4972] Add comment sort bar (#9477) JD Francis

This reverts commit bfaa536.

[58bdb34] [PAY-3324] Purchase/Sales details w/ take rate (#9602) Marcus Pasell [ebf9040] Support negative fractional numbers in FixedDecimal, default USDC formatting (#9600) Marcus Pasell [fa2ac4c] [C-4953] Mobile comments editing + replying (#9584) Sebastian Klingler [ed697c2] New audius-query hook for paginated queries (#9592) JD Francis [847c075] [PAY-3319][PAY-3399] Update Discovery to support new purchase transaction details (#9586) Marcus Pasell [760bfee] Center long track/collection titles on mobile (#9598) Reed [c18d431] [C-4799] Add mobile-web comments (#9578) Dylan Jeffers [74ab87e] [PAY-3388] Add user feed V1 endpoint (#9583) Randy Schott [f9ae82a] [QA-1510] Simplify hover gradient styles coming from harmony (#9590) Raymond Jacobson [86343d1] Fix search filters (#9595) Sebastian Klingler [398190f] [QA-1498] Reland fix to QA-1498 (#9582) Raymond Jacobson [0b92de2] Revert "Enabling blocking users from commenting (#9469)" (#9552) Isaac Solo [27b6332] [QA-1531][QA-1535] Fix mobile track page issues (#9589) Raymond Jacobson [7649131] Remove quality toggle for mobile downloads (#9587) Reed [92737e3] [PAY-3372] Add sales aggregate endpoint (#9585) Andrew Mendelsohn [ef67166] [QA-1536] Remove download all buttons (#9581) Reed [83bb4bb] Set default comment entity_type in indexing (#9580) Dylan Jeffers [331111e] Update dapp-store build artifacts audius-infra [d08cce0] Fix mobile composer input newlines and unfurl overflow (#9575) Raymond Jacobson [7eb83d7] Fix broken offline mode (#9571) Raymond Jacobson [906f90a] [PAY-3377] Migrate remaining apiClient endpoints to SDK (#9559) Randy Schott [c908aef] Fix mobile comment overflow menu lint (#9577) Dylan Jeffers [0188a6a] [QA-875][QA-850] Fix lineup pagination when dupes are present (#9572) Raymond Jacobson [c83ca67] [PAY-3394] Maintain chat list sort order on blast (#9568) Reed [7470a55] [PAY-3397] Fix mobile layout with UserGeneratedText in DMs (#9570) Raymond Jacobson [2c39178] [PAY-3374] Fix selection colors for composer (#9565) Raymond Jacobson [78a028e] Update comment-section-api (#9551) Dylan Jeffers [fedd220] [PAY-3384] Implement web pay with anything (#9279) Raymond Jacobson [51e911f] [C-4981] Comments desktop tweaks (designer QA) (#9548) JD Francis [fa43c8d] [PAY-3152] Fix Accounts You Manage modal showing after switching accounts (#9558) Randy Schott [39c7764] [PAY-3371] Add endpoint to get tracks by user that have been remixed (#9554) Andrew Mendelsohn [39a1ec1] [QA-1526] Hotfix pagination issues (#9557) JD Francis [cb1446c] Fix types on harmony virtualized (#9553) Raymond Jacobson [c4965de] [C-4955] Comment action drawer (#9534) Sebastian Klingler [713712e] [PAY-2919] Migrate playlists endpoints from apiClient -> sdk (#9535) Randy Schott [f8c197f] [QA-1016] Fix playlist creation from track added time (#9529) Raymond Jacobson [ba1aaed] Fix trending reward notifs (#9532) Isaac Solo [303614d] Add virtualized filter button, Fix option select (#9543) Dylan Jeffers [97ac58e] Bump mobile apps to 1.1.112 Dylan Jeffers [c10b064] [PAY-3348] Remove dead withdrawals code (#9542) Marcus Pasell

[b87f574] Fix Splits Migration: Stage has users w/o indexed user banks (#9604) Marcus Pasell [847c075] [PAY-3319][PAY-3399] Update Discovery to support new purchase transaction details (#9586) Marcus Pasell [74ab87e] [PAY-3388] Add user feed V1 endpoint (#9583) Randy Schott [5c520c1] [QA-1533] Filter out deactivated users from UserList queries (#9596) Reed [c52e0cb] Filter genre metrics endpoint by allowlist (#9591) Randy Schott [0b92de2] Revert "Enabling blocking users from commenting (#9469)" (#9552) Isaac Solo

Enabling blocking users from commenting

d88bcc7

pull-request-size bot added the size/M label Aug 15, 2024

isaacsolo requested a review from DejayJD August 15, 2024 22:55

isaacsolo requested a review from sliptype August 16, 2024 16:39

DejayJD reviewed Aug 16, 2024

View reviewed changes

DejayJD approved these changes Aug 16, 2024

View reviewed changes

sliptype approved these changes Aug 19, 2024

View reviewed changes

fix tests

3356875

fix lint

c1bb49e

isaacsolo merged commit bfaa536 into main Aug 19, 2024

isaacsolo deleted the is-block-user-comments branch August 19, 2024 17:32

isaacsolo pushed a commit that referenced this pull request Aug 26, 2024

Revert "Enabling blocking users from commenting (#9469)"

8bdd598

This reverts commit bfaa536.

DejayJD pushed a commit that referenced this pull request Aug 30, 2024

Revert "Enabling blocking users from commenting (#9469)" (#9552)

0b92de2

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enabling blocking users from commenting #9469

Enabling blocking users from commenting #9469

Uh oh!

isaacsolo commented Aug 15, 2024

Uh oh!

changeset-bot bot commented Aug 15, 2024 •

edited

Loading

Uh oh!

audius-infra commented Aug 15, 2024

Uh oh!

DejayJD Aug 16, 2024

Uh oh!

isaacsolo Aug 16, 2024

Uh oh!

DejayJD Aug 16, 2024 •

edited

Loading

Uh oh!

isaacsolo Aug 16, 2024

Uh oh!

DejayJD left a comment •

edited

Loading

Uh oh!

DejayJD Aug 16, 2024

Uh oh!

gitguardian bot commented Aug 19, 2024 •

edited

Loading

Uh oh!

audius-infra commented Aug 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Enabling blocking users from commenting #9469

Enabling blocking users from commenting #9469

Uh oh!

Conversation

isaacsolo commented Aug 15, 2024

Description

How Has This Been Tested?

Uh oh!

changeset-bot bot commented Aug 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

audius-infra commented Aug 15, 2024

Uh oh!

DejayJD Aug 16, 2024

Choose a reason for hiding this comment

Uh oh!

isaacsolo Aug 16, 2024

Choose a reason for hiding this comment

Uh oh!

DejayJD Aug 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

isaacsolo Aug 16, 2024

Choose a reason for hiding this comment

Uh oh!

DejayJD left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DejayJD Aug 16, 2024

Choose a reason for hiding this comment

Uh oh!

gitguardian bot commented Aug 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Uh oh!

audius-infra commented Aug 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

changeset-bot bot commented Aug 15, 2024 •

edited

Loading

DejayJD Aug 16, 2024 •

edited

Loading

DejayJD left a comment •

edited

Loading

gitguardian bot commented Aug 19, 2024 •

edited

Loading