[C-4981] Comments desktop tweaks (designer QA) #9548

DejayJD · 2024-08-26T19:32:09Z

Description

Some tweaks based off of designer QA

This header thing looks better now
Avatar sizing was off by 4px
Avatar in comment block now links to users
Avatar & text also show the user link popover now
Comment header kebab menu no longer shows only on hover (designers agreed to keep it showing)

How Has This Been Tested?

web:stage

changeset-bot · 2024-08-26T19:32:13Z

⚠️ No Changeset found

Latest commit: 9ce7e42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

audius-infra · 2024-08-26T19:42:31Z

Preview this change https://demo.audius.co/jd/comments-qa

dylanjeffers

Looks great

dylanjeffers · 2024-08-26T19:43:51Z

packages/web/src/components/comments/CommentBlock.tsx

-      />
+      <Box css={{ flexShrink: 0 }}>
+        <UserLink userId={commentUserId} disabled={isDeleting} popover noText>
+          <Avatar


Do we not have user avatar?

Hmm I dont see one; would be a good add tho! I'll toss that in

wait nvm we do; its just Avatar in /components

…ocol into jd/comments-qa

audius-infra · 2024-08-27T20:36:06Z

Preview this change https://demo.audius.co/jd/comments-qa

…jd/comments-qa

gitguardian · 2024-08-27T21:36:45Z

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
9349019	Triggered	Generic High Entropy Secret	`9ce7e42`	dev-tools/config.json	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secret safely. Learn here the best practices.
Revoke and rotate this secret.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

audius-infra · 2024-08-27T21:50:49Z

Preview this change https://demo.audius.co/jd/comments-qa

…-apiClient * origin/main: Live reload for comms server (#9567) [PAY-3374] Fix selection colors for composer (#9565) Audius Protocol v0.6.178 Use max(created_at) for chat_blast last_message_at (#9562) Update comment-section-api (#9551) [PAY-3384] Implement web pay with anything (#9279) [C-4981] Comments desktop tweaks (designer QA) (#9548) Update python package for dn dockerfile (#9560) [PAY-3152] Fix Accounts You Manage modal showing after switching accounts (#9558) [PAY-3371] Add endpoint to get tracks by user that have been remixed (#9554) Use owner wallet as the staking bridge program address when runing locally (#9556) [QA-1526] Hotfix pagination issues (#9557) Fix types on harmony virtualized (#9553) [C-4955] Comment action drawer (#9534) Audius Protocol v0.6.177

[58bdb34] [PAY-3324] Purchase/Sales details w/ take rate (#9602) Marcus Pasell [ebf9040] Support negative fractional numbers in FixedDecimal, default USDC formatting (#9600) Marcus Pasell [fa2ac4c] [C-4953] Mobile comments editing + replying (#9584) Sebastian Klingler [ed697c2] New audius-query hook for paginated queries (#9592) JD Francis [847c075] [PAY-3319][PAY-3399] Update Discovery to support new purchase transaction details (#9586) Marcus Pasell [760bfee] Center long track/collection titles on mobile (#9598) Reed [c18d431] [C-4799] Add mobile-web comments (#9578) Dylan Jeffers [74ab87e] [PAY-3388] Add user feed V1 endpoint (#9583) Randy Schott [f9ae82a] [QA-1510] Simplify hover gradient styles coming from harmony (#9590) Raymond Jacobson [86343d1] Fix search filters (#9595) Sebastian Klingler [398190f] [QA-1498] Reland fix to QA-1498 (#9582) Raymond Jacobson [0b92de2] Revert "Enabling blocking users from commenting (#9469)" (#9552) Isaac Solo [27b6332] [QA-1531][QA-1535] Fix mobile track page issues (#9589) Raymond Jacobson [7649131] Remove quality toggle for mobile downloads (#9587) Reed [92737e3] [PAY-3372] Add sales aggregate endpoint (#9585) Andrew Mendelsohn [ef67166] [QA-1536] Remove download all buttons (#9581) Reed [83bb4bb] Set default comment entity_type in indexing (#9580) Dylan Jeffers [331111e] Update dapp-store build artifacts audius-infra [d08cce0] Fix mobile composer input newlines and unfurl overflow (#9575) Raymond Jacobson [7eb83d7] Fix broken offline mode (#9571) Raymond Jacobson [906f90a] [PAY-3377] Migrate remaining apiClient endpoints to SDK (#9559) Randy Schott [c908aef] Fix mobile comment overflow menu lint (#9577) Dylan Jeffers [0188a6a] [QA-875][QA-850] Fix lineup pagination when dupes are present (#9572) Raymond Jacobson [c83ca67] [PAY-3394] Maintain chat list sort order on blast (#9568) Reed [7470a55] [PAY-3397] Fix mobile layout with UserGeneratedText in DMs (#9570) Raymond Jacobson [2c39178] [PAY-3374] Fix selection colors for composer (#9565) Raymond Jacobson [78a028e] Update comment-section-api (#9551) Dylan Jeffers [fedd220] [PAY-3384] Implement web pay with anything (#9279) Raymond Jacobson [51e911f] [C-4981] Comments desktop tweaks (designer QA) (#9548) JD Francis [fa43c8d] [PAY-3152] Fix Accounts You Manage modal showing after switching accounts (#9558) Randy Schott [39c7764] [PAY-3371] Add endpoint to get tracks by user that have been remixed (#9554) Andrew Mendelsohn [39a1ec1] [QA-1526] Hotfix pagination issues (#9557) JD Francis [cb1446c] Fix types on harmony virtualized (#9553) Raymond Jacobson [c4965de] [C-4955] Comment action drawer (#9534) Sebastian Klingler [713712e] [PAY-2919] Migrate playlists endpoints from apiClient -> sdk (#9535) Randy Schott [f8c197f] [QA-1016] Fix playlist creation from track added time (#9529) Raymond Jacobson [ba1aaed] Fix trending reward notifs (#9532) Isaac Solo [303614d] Add virtualized filter button, Fix option select (#9543) Dylan Jeffers [97ac58e] Bump mobile apps to 1.1.112 Dylan Jeffers [c10b064] [PAY-3348] Remove dead withdrawals code (#9542) Marcus Pasell

DejayJD added 4 commits August 26, 2024 13:14

fix avatar size

b66e58c

Fix spacing and make avatar clickable

f6e29c4

Fix comment block header centering & sizing

29e5d97

Add user @ to replies

a1668f9

DejayJD requested review from Kyle-Shanks, dylanjeffers and isaacsolo August 26, 2024 19:32

pull-request-size bot added the size/M label Aug 26, 2024

dylanjeffers approved these changes Aug 26, 2024

View reviewed changes

DejayJD added 3 commits August 27, 2024 15:11

Replace Avatar with the web/components version

5e185bc

Replace Avatar with the web/components version

a6c8cd5

Merge branch 'jd/comments-qa' of github.com:AudiusProject/audius-prot…

6d91c5c

…ocol into jd/comments-qa

Merge branch 'main' of github.com:AudiusProject/audius-protocol into …

9ce7e42

…jd/comments-qa

DejayJD merged commit 51e911f into main Aug 27, 2024

DejayJD deleted the jd/comments-qa branch August 27, 2024 22:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[C-4981] Comments desktop tweaks (designer QA) #9548

[C-4981] Comments desktop tweaks (designer QA) #9548

Uh oh!

DejayJD commented Aug 26, 2024 •

edited

Loading

Uh oh!

changeset-bot bot commented Aug 26, 2024 •

edited

Loading

Uh oh!

audius-infra commented Aug 26, 2024

Uh oh!

dylanjeffers left a comment

Uh oh!

dylanjeffers Aug 26, 2024

Uh oh!

DejayJD Aug 27, 2024

Uh oh!

DejayJD Aug 27, 2024 •

edited

Loading

Uh oh!

audius-infra commented Aug 27, 2024

Uh oh!

gitguardian bot commented Aug 27, 2024

Uh oh!

audius-infra commented Aug 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

[C-4981] Comments desktop tweaks (designer QA) #9548

[C-4981] Comments desktop tweaks (designer QA) #9548

Uh oh!

Conversation

DejayJD commented Aug 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Uh oh!

changeset-bot bot commented Aug 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

audius-infra commented Aug 26, 2024

Uh oh!

dylanjeffers left a comment

Choose a reason for hiding this comment

Uh oh!

dylanjeffers Aug 26, 2024

Choose a reason for hiding this comment

Uh oh!

DejayJD Aug 27, 2024

Choose a reason for hiding this comment

Uh oh!

DejayJD Aug 27, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

audius-infra commented Aug 27, 2024

Uh oh!

gitguardian bot commented Aug 27, 2024

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Uh oh!

audius-infra commented Aug 27, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

DejayJD commented Aug 26, 2024 •

edited

Loading

changeset-bot bot commented Aug 26, 2024 •

edited

Loading

DejayJD Aug 27, 2024 •

edited

Loading