[C-4799] Add mobile-web comments #9578
Conversation
|
dylanjeffers
changed the title
dylanjeffers
changed the title
|
Preview this change https://demo.audius.co/c-4799-mobile-web-comments |
| component={AiAttributedTracksPage} | ||
| /> | ||
| <Route exact path={TRACK_PAGE} component={TrackPage} /> | ||
| <MobileRoute |
There was a problem hiding this comment.
lol I forgot that these are in the "WebPlayer" component 💀
| const messages = { | ||
| postComment: 'Post Comment', | ||
| addComment: 'Add a comment', | ||
| firstComment: 'Be the first to comment!' | ||
| } |
There was a problem hiding this comment.
nit: doesnt need to be part of this PR but I wonder if we should move these into common to share with native
There was a problem hiding this comment.
yeah i can get that started!
|
|
||
| // Empty state | ||
| if (!comments || !comments.length) { | ||
| return ( |
There was a problem hiding this comment.
Does it make sense to combine this with the NoComments component? If not maybe we move that component inside the desktop file
There was a problem hiding this comment.
yeah it's a pretty different layout... sure i can move it inside desktop for now, and maybe we have a consolidation run later with mobile-web and desktop as much as seems reasonable
There was a problem hiding this comment.
Yeah it's a pretty small component anyways and I debated about it having it's own file.
I think to avoid confusion with mobile would be good to move it away from its own file then 👌
| <PlainButton | ||
| onClick={() => toggleReplies(rootComment.id)} | ||
| variant='subdued' | ||
| iconLeft={ | ||
| hiddenReplies[rootComment.id] ? IconCaretDown : IconCaretUp | ||
| } | ||
| fullWidth={false} | ||
| > | ||
| {hiddenReplies[rootComment.id] | ||
| ? messages.showReplies | ||
| : messages.hideReplies} | ||
| </PlainButton> |
|
|
||
| return ( | ||
| <Flex direction='column'> | ||
| <Flex direction='column' as='li'> |
[58bdb34] [PAY-3324] Purchase/Sales details w/ take rate (#9602) Marcus Pasell [ebf9040] Support negative fractional numbers in FixedDecimal, default USDC formatting (#9600) Marcus Pasell [fa2ac4c] [C-4953] Mobile comments editing + replying (#9584) Sebastian Klingler [ed697c2] New audius-query hook for paginated queries (#9592) JD Francis [847c075] [PAY-3319][PAY-3399] Update Discovery to support new purchase transaction details (#9586) Marcus Pasell [760bfee] Center long track/collection titles on mobile (#9598) Reed [c18d431] [C-4799] Add mobile-web comments (#9578) Dylan Jeffers [74ab87e] [PAY-3388] Add user feed V1 endpoint (#9583) Randy Schott [f9ae82a] [QA-1510] Simplify hover gradient styles coming from harmony (#9590) Raymond Jacobson [86343d1] Fix search filters (#9595) Sebastian Klingler [398190f] [QA-1498] Reland fix to QA-1498 (#9582) Raymond Jacobson [0b92de2] Revert "Enabling blocking users from commenting (#9469)" (#9552) Isaac Solo [27b6332] [QA-1531][QA-1535] Fix mobile track page issues (#9589) Raymond Jacobson [7649131] Remove quality toggle for mobile downloads (#9587) Reed [92737e3] [PAY-3372] Add sales aggregate endpoint (#9585) Andrew Mendelsohn [ef67166] [QA-1536] Remove download all buttons (#9581) Reed [83bb4bb] Set default comment entity_type in indexing (#9580) Dylan Jeffers [331111e] Update dapp-store build artifacts audius-infra [d08cce0] Fix mobile composer input newlines and unfurl overflow (#9575) Raymond Jacobson [7eb83d7] Fix broken offline mode (#9571) Raymond Jacobson [906f90a] [PAY-3377] Migrate remaining apiClient endpoints to SDK (#9559) Randy Schott [c908aef] Fix mobile comment overflow menu lint (#9577) Dylan Jeffers [0188a6a] [QA-875][QA-850] Fix lineup pagination when dupes are present (#9572) Raymond Jacobson [c83ca67] [PAY-3394] Maintain chat list sort order on blast (#9568) Reed [7470a55] [PAY-3397] Fix mobile layout with UserGeneratedText in DMs (#9570) Raymond Jacobson [2c39178] [PAY-3374] Fix selection colors for composer (#9565) Raymond Jacobson [78a028e] Update comment-section-api (#9551) Dylan Jeffers [fedd220] [PAY-3384] Implement web pay with anything (#9279) Raymond Jacobson [51e911f] [C-4981] Comments desktop tweaks (designer QA) (#9548) JD Francis [fa43c8d] [PAY-3152] Fix Accounts You Manage modal showing after switching accounts (#9558) Randy Schott [39c7764] [PAY-3371] Add endpoint to get tracks by user that have been remixed (#9554) Andrew Mendelsohn [39a1ec1] [QA-1526] Hotfix pagination issues (#9557) JD Francis [cb1446c] Fix types on harmony virtualized (#9553) Raymond Jacobson [c4965de] [C-4955] Comment action drawer (#9534) Sebastian Klingler [713712e] [PAY-2919] Migrate playlists endpoints from apiClient -> sdk (#9535) Randy Schott [f8c197f] [QA-1016] Fix playlist creation from track added time (#9529) Raymond Jacobson [ba1aaed] Fix trending reward notifs (#9532) Isaac Solo [303614d] Add virtualized filter button, Fix option select (#9543) Dylan Jeffers [97ac58e] Bump mobile apps to 1.1.112 Dylan Jeffers [c10b064] [PAY-3348] Remove dead withdrawals code (#9542) Marcus Pasell
3 participants
Description
Adds mobile-web comments, reusing as much as possible from desktop comments.
TODO: