Skip to content

[PAY-3152] Fix Accounts You Manage modal showing after switching accounts #9558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
schottra merged 2 commits into from
Aug 27, 2024
Merged

[PAY-3152] Fix Accounts You Manage modal showing after switching accounts #9558

schottra merged 2 commits into from
Aug 27, 2024

Conversation

@schottra
Copy link
Contributor

@schottra schottra commented Aug 27, 2024

Description

There was an edge case with the new manager flow:

  1. Click on a deeplink to open the 'Accounts You Manage' modal
  2. Do whatever in the modal and then close it
  3. Switch accounts

The page will refresh with the /accounts-you-manage suffix still on the URL, which will trigger showing the 'Accounts You Manage' modal for the managed account. This is usually not what we want.

Easy fix: when closing the modal, remove the suffix from the route.

How Has This Been Tested?

Tested locally against staging.

@changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 38dddb3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@schottra schottra enabled auto-merge (squash) August 27, 2024 15:45
@schottra schottra requested a review from rickyrombo August 27, 2024 15:45
@audius-infra
Copy link
Collaborator

audius-infra commented Aug 27, 2024

Preview this change https://demo.audius.co/pay-3152-stale-deeplink

raymondjacobson
raymondjacobson approved these changes Aug 27, 2024
View reviewed changes
...web/src/pages/settings-page/components/desktop/ManagerMode/AccountsYouManageSettingsCard.tsx Outdated
const [isModalOpen, setIsModalOpen] = useState(false)
const dispatch = useDispatch()
const location = useLocation()
const isManagedAccountsRoute = doesMatchRoute(
Copy link
Member

@raymondjacobson raymondjacobson Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe worth memoizing this still? / keeping inside effects?

Copy link
Contributor Author

@schottra schottra Aug 27, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@audius-infra
Copy link
Collaborator

audius-infra commented Aug 27, 2024

Preview this change https://demo.audius.co/pay-3152-stale-deeplink

@schottra schottra disabled auto-merge August 27, 2024 20:28
@schottra schottra merged commit fa43c8d into main Aug 27, 2024
@schottra schottra deleted the pay-3152-stale-deeplink branch August 27, 2024 20:29
schottra added a commit that referenced this pull request Aug 28, 2024
@schottra
Merge remote-tracking branch 'origin/main' into pay-3377-migrate-misc…
04c929a 
…-apiClient

* origin/main:
  Live reload for comms server (#9567)
  [PAY-3374] Fix selection colors for composer (#9565)
  Audius Protocol v0.6.178
  Use max(created_at) for chat_blast last_message_at (#9562)
  Update comment-section-api (#9551)
  [PAY-3384] Implement web pay with anything (#9279)
  [C-4981] Comments desktop tweaks (designer QA) (#9548)
  Update python package for dn dockerfile (#9560)
  [PAY-3152] Fix Accounts You Manage modal showing after switching accounts (#9558)
  [PAY-3371] Add endpoint to get tracks by user that have been remixed (#9554)
  Use owner wallet as the staking bridge program address when runing locally (#9556)
  [QA-1526] Hotfix pagination issues (#9557)
  Fix types on harmony virtualized (#9553)
  [C-4955] Comment action drawer (#9534)
  Audius Protocol v0.6.177
audius-infra pushed a commit that referenced this pull request Aug 31, 2024
Audius Client (Web and Mobile) v1.5.97
b24b804 
[58bdb34] [PAY-3324] Purchase/Sales details w/ take rate (#9602) Marcus Pasell
[ebf9040] Support negative fractional numbers in FixedDecimal, default USDC formatting (#9600) Marcus Pasell
[fa2ac4c] [C-4953] Mobile comments editing + replying (#9584) Sebastian Klingler
[ed697c2] New audius-query hook for paginated queries (#9592) JD Francis
[847c075] [PAY-3319][PAY-3399] Update Discovery to support new purchase transaction details (#9586) Marcus Pasell
[760bfee] Center long track/collection titles on mobile (#9598) Reed
[c18d431] [C-4799] Add mobile-web comments (#9578) Dylan Jeffers
[74ab87e] [PAY-3388] Add user feed V1 endpoint (#9583) Randy Schott
[f9ae82a] [QA-1510] Simplify hover gradient styles coming from harmony (#9590) Raymond Jacobson
[86343d1] Fix search filters (#9595) Sebastian Klingler
[398190f] [QA-1498] Reland fix to QA-1498 (#9582) Raymond Jacobson
[0b92de2] Revert "Enabling blocking users from commenting (#9469)" (#9552) Isaac Solo
[27b6332] [QA-1531][QA-1535] Fix mobile track page issues (#9589) Raymond Jacobson
[7649131] Remove quality toggle for mobile downloads (#9587) Reed
[92737e3] [PAY-3372] Add sales aggregate endpoint (#9585) Andrew Mendelsohn
[ef67166] [QA-1536] Remove download all buttons (#9581) Reed
[83bb4bb] Set default comment entity_type in indexing (#9580) Dylan Jeffers
[331111e] Update dapp-store build artifacts audius-infra
[d08cce0] Fix mobile composer input newlines and unfurl overflow (#9575) Raymond Jacobson
[7eb83d7] Fix broken offline mode (#9571) Raymond Jacobson
[906f90a] [PAY-3377] Migrate remaining apiClient endpoints to SDK (#9559) Randy Schott
[c908aef] Fix mobile comment overflow menu lint (#9577) Dylan Jeffers
[0188a6a] [QA-875][QA-850] Fix lineup pagination when dupes are present (#9572) Raymond Jacobson
[c83ca67] [PAY-3394] Maintain chat list sort order on blast (#9568) Reed
[7470a55] [PAY-3397] Fix mobile layout with UserGeneratedText in DMs (#9570) Raymond Jacobson
[2c39178] [PAY-3374] Fix selection colors for composer (#9565) Raymond Jacobson
[78a028e] Update comment-section-api (#9551) Dylan Jeffers
[fedd220] [PAY-3384] Implement web pay with anything (#9279) Raymond Jacobson
[51e911f] [C-4981] Comments desktop tweaks (designer QA) (#9548) JD Francis
[fa43c8d] [PAY-3152] Fix Accounts You Manage modal showing after switching accounts (#9558) Randy Schott
[39c7764] [PAY-3371] Add endpoint to get tracks by user that have been remixed (#9554) Andrew Mendelsohn
[39a1ec1] [QA-1526] Hotfix pagination issues (#9557) JD Francis
[cb1446c] Fix types on harmony virtualized (#9553) Raymond Jacobson
[c4965de] [C-4955] Comment action drawer (#9534) Sebastian Klingler
[713712e] [PAY-2919] Migrate playlists endpoints from apiClient -> sdk (#9535) Randy Schott
[f8c197f] [QA-1016] Fix playlist creation from track added time (#9529) Raymond Jacobson
[ba1aaed] Fix trending reward notifs (#9532) Isaac Solo
[303614d] Add virtualized filter button, Fix option select (#9543) Dylan Jeffers
[97ac58e] Bump mobile apps to 1.1.112 Dylan Jeffers
[c10b064] [PAY-3348] Remove dead withdrawals code (#9542) Marcus Pasell
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@raymondjacobson raymondjacobson raymondjacobson approved these changes

@rickyrombo rickyrombo rickyrombo approved these changes

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@schottra @audius-infra @raymondjacobson @rickyrombo