[PAY-3384] Implement web pay with anything #9279

raymondjacobson · 2024-07-26T16:25:56Z

Description

Some mobile code is present here for layout, but it is all hidden behind a boolean that is currently turned off

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Purchased track with $WIF
Purchased album with $WIF

…-anything

changeset-bot · 2024-07-26T16:26:00Z

⚠️ No Changeset found

Latest commit: 59cd22d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

audius-infra · 2024-07-26T16:44:03Z

Preview this change https://demo.audius.co/hackathon-pay-with-anything

audius-infra · 2024-07-26T17:01:37Z

Preview this change https://demo.audius.co/hackathon-pay-with-anything

audius-infra · 2024-07-26T17:33:07Z

Preview this change https://demo.audius.co/hackathon-pay-with-anything

audius-infra · 2024-07-26T19:04:49Z

Preview this change https://demo.audius.co/hackathon-pay-with-anything

…ything

gitguardian · 2024-08-26T07:18:08Z

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request

GitGuardian id	GitGuardian status	Secret	Commit	Filename
9349019	Triggered	Generic High Entropy Secret	`a863cc7`	dev-tools/config.json	View secret
13407071	Triggered	Generic High Entropy Secret	`f3593ad`	comms/Makefile	View secret

🛠 Guidelines to remediate hardcoded secrets

Understand the implications of revoking this secret by investigating where it is used in your code.
Replace and store your secrets safely. Learn here the best practices.
Revoke and rotate these secrets.
If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider

following these best practices for managing and storing secrets including API keys and other credentials
install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.

^{🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.}

audius-infra · 2024-08-26T07:45:49Z

Preview this change https://demo.audius.co/hackathon-pay-with-anything

raymondjacobson · 2024-08-26T19:28:03Z

packages/common/src/store/purchase-content/sagas.ts

+        contentType === PurchaseableContentType.TRACK ? 'track' : 'album'
+      } with id ${contentId}...`
+    )
+    if (contentType === PurchaseableContentType.TRACK) {


consider not going through user bank?

so which wallet would we provide in this case? the payout wallet?

yeah, talked about this at the monetization sync yday, but we could probably do a "direct to recipient" flow here.
want to check this version in first just to make sure we hit timelines, but can def re-eval

…ything

raymondjacobson · 2024-08-27T01:43:02Z

There could be more cleanup, but want to merge this early to avoid too many conflict!

audius-infra · 2024-08-27T01:55:50Z

Preview this change https://demo.audius.co/hackathon-pay-with-anything

audius-infra · 2024-08-27T02:11:08Z

Preview this change https://demo.audius.co/hackathon-pay-with-anything

…ything

audius-infra · 2024-08-27T06:50:49Z

Preview this change https://demo.audius.co/hackathon-pay-with-anything

dylanjeffers

great work!!

packages/common/src/store/purchase-content/sagas.ts

dylanjeffers · 2024-08-27T16:53:11Z

packages/common/src/store/purchase-content/sagas.ts

+
+    // Get the solana wallet provider
+    const provider = window.solana
+    if (!provider) return


throw error? or we thinking basically cant happen since pay-with-anything would never have been called?

nice good to throw anyway

dylanjeffers · 2024-08-27T17:01:48Z

packages/common/src/store/purchase-content/sagas.ts

+        contentType === PurchaseableContentType.TRACK ? 'track' : 'album'
+      } with id ${contentId}...`
+    )
+    if (contentType === PurchaseableContentType.TRACK) {


so which wallet would we provide in this case? the payout wallet?

packages/web/src/components/summary-table/SummaryTable.tsx

packages/web/src/components/track/LockedContentDetailsTile.tsx

audius-infra · 2024-08-28T00:09:00Z

Preview this change https://demo.audius.co/hackathon-pay-with-anything

…ything

audius-infra · 2024-08-28T03:12:24Z

Preview this change https://demo.audius.co/hackathon-pay-with-anything

…-apiClient * origin/main: Live reload for comms server (#9567) [PAY-3374] Fix selection colors for composer (#9565) Audius Protocol v0.6.178 Use max(created_at) for chat_blast last_message_at (#9562) Update comment-section-api (#9551) [PAY-3384] Implement web pay with anything (#9279) [C-4981] Comments desktop tweaks (designer QA) (#9548) Update python package for dn dockerfile (#9560) [PAY-3152] Fix Accounts You Manage modal showing after switching accounts (#9558) [PAY-3371] Add endpoint to get tracks by user that have been remixed (#9554) Use owner wallet as the staking bridge program address when runing locally (#9556) [QA-1526] Hotfix pagination issues (#9557) Fix types on harmony virtualized (#9553) [C-4955] Comment action drawer (#9534) Audius Protocol v0.6.177

[58bdb34] [PAY-3324] Purchase/Sales details w/ take rate (#9602) Marcus Pasell [ebf9040] Support negative fractional numbers in FixedDecimal, default USDC formatting (#9600) Marcus Pasell [fa2ac4c] [C-4953] Mobile comments editing + replying (#9584) Sebastian Klingler [ed697c2] New audius-query hook for paginated queries (#9592) JD Francis [847c075] [PAY-3319][PAY-3399] Update Discovery to support new purchase transaction details (#9586) Marcus Pasell [760bfee] Center long track/collection titles on mobile (#9598) Reed [c18d431] [C-4799] Add mobile-web comments (#9578) Dylan Jeffers [74ab87e] [PAY-3388] Add user feed V1 endpoint (#9583) Randy Schott [f9ae82a] [QA-1510] Simplify hover gradient styles coming from harmony (#9590) Raymond Jacobson [86343d1] Fix search filters (#9595) Sebastian Klingler [398190f] [QA-1498] Reland fix to QA-1498 (#9582) Raymond Jacobson [0b92de2] Revert "Enabling blocking users from commenting (#9469)" (#9552) Isaac Solo [27b6332] [QA-1531][QA-1535] Fix mobile track page issues (#9589) Raymond Jacobson [7649131] Remove quality toggle for mobile downloads (#9587) Reed [92737e3] [PAY-3372] Add sales aggregate endpoint (#9585) Andrew Mendelsohn [ef67166] [QA-1536] Remove download all buttons (#9581) Reed [83bb4bb] Set default comment entity_type in indexing (#9580) Dylan Jeffers [331111e] Update dapp-store build artifacts audius-infra [d08cce0] Fix mobile composer input newlines and unfurl overflow (#9575) Raymond Jacobson [7eb83d7] Fix broken offline mode (#9571) Raymond Jacobson [906f90a] [PAY-3377] Migrate remaining apiClient endpoints to SDK (#9559) Randy Schott [c908aef] Fix mobile comment overflow menu lint (#9577) Dylan Jeffers [0188a6a] [QA-875][QA-850] Fix lineup pagination when dupes are present (#9572) Raymond Jacobson [c83ca67] [PAY-3394] Maintain chat list sort order on blast (#9568) Reed [7470a55] [PAY-3397] Fix mobile layout with UserGeneratedText in DMs (#9570) Raymond Jacobson [2c39178] [PAY-3374] Fix selection colors for composer (#9565) Raymond Jacobson [78a028e] Update comment-section-api (#9551) Dylan Jeffers [fedd220] [PAY-3384] Implement web pay with anything (#9279) Raymond Jacobson [51e911f] [C-4981] Comments desktop tweaks (designer QA) (#9548) JD Francis [fa43c8d] [PAY-3152] Fix Accounts You Manage modal showing after switching accounts (#9558) Randy Schott [39c7764] [PAY-3371] Add endpoint to get tracks by user that have been remixed (#9554) Andrew Mendelsohn [39a1ec1] [QA-1526] Hotfix pagination issues (#9557) JD Francis [cb1446c] Fix types on harmony virtualized (#9553) Raymond Jacobson [c4965de] [C-4955] Comment action drawer (#9534) Sebastian Klingler [713712e] [PAY-2919] Migrate playlists endpoints from apiClient -> sdk (#9535) Randy Schott [f8c197f] [QA-1016] Fix playlist creation from track added time (#9529) Raymond Jacobson [ba1aaed] Fix trending reward notifs (#9532) Isaac Solo [303614d] Add virtualized filter button, Fix option select (#9543) Dylan Jeffers [97ac58e] Bump mobile apps to 1.1.112 Dylan Jeffers [c10b064] [PAY-3348] Remove dead withdrawals code (#9542) Marcus Pasell

Saliou Diallo and others added 16 commits July 25, 2024 12:16

Add feature flag

50c405a

Add pay with anything option

c22586d

Add support for token selection

4f69c5d

Add virtualized option to OptionsFilterButton

1074400

Wire through to saga

8da616a

Wire through purchaseMethodMintAddress

a9455bb

wip: close

873951e

Fix amounts

dbcabee

done, almost

4fdb9d4

Cleanup 1

d75d003

Cleanup 2

bca7d64

Cleanup 3

88fd8a1

Merge branch 'sd-hackathon-pay-with-anything' into hackathon-pay-with…

f96bafc

…-anything

Add flag and window.solana check

b232827

Remove temp button

9ce9c4d

Combine UI with sagas. It works for both tracks and albums.

8b7dd42

pull-request-size bot added the size/XL label Jul 26, 2024

Saliou Diallo and others added 3 commits July 26, 2024 12:26

Lint

471a782

Make mint address params optional in payment method

50c3b48

Toggle method when token picker is opened

1f1a0d6

Saliou Diallo added 2 commits July 26, 2024 13:08

Add error for insufficient external token balance

c7978ba

Default to pay with card on advanced options failure

249f91d

Saliou Diallo added 2 commits July 26, 2024 14:17

Include conditional usdc ata creation in swap and send transaction

574ecea

Fix copy

a319a00

Implement token picker on mobile

18b6a57

raymondjacobson added 2 commits August 25, 2024 23:41

Merge remote-tracking branch 'origin/main' into hackathon-pay-with-an…

f3593ad

…ything

Support virtualized in filter button

30f069d

Minor fixes

7a65293

raymondjacobson commented Aug 26, 2024

View reviewed changes

raymondjacobson added 3 commits August 26, 2024 16:54

Merge remote-tracking branch 'origin/main' into hackathon-pay-with-an…

2d6d38d

…ything

Merge fix

3c10bc0

Fix filter button usage

a07907c

raymondjacobson changed the title ~~Pay with anything~~ [PAY-3384] Implement web pay with anything Aug 27, 2024

Add new UI

a486662

raymondjacobson force-pushed the hackathon-pay-with-anything branch from 43d89a5 to a486662 Compare August 27, 2024 01:41

raymondjacobson requested review from dylanjeffers and rickyrombo August 27, 2024 01:42

Poll for balance before continue

b06d5d1

Merge remote-tracking branch 'origin/main' into hackathon-pay-with-an…

7ad6a17

…ything

dylanjeffers approved these changes Aug 27, 2024

View reviewed changes

Address dylan comments, fix circular payment

979eb8b

raymondjacobson added 2 commits August 27, 2024 19:51

Merge remote-tracking branch 'origin/main' into hackathon-pay-with-an…

a863cc7

…ything

Fixt test

59cd22d

raymondjacobson merged commit fedd220 into main Aug 28, 2024

raymondjacobson deleted the hackathon-pay-with-anything branch August 28, 2024 07:58

[PAY-3384] Implement web pay with anything #9279

[PAY-3384] Implement web pay with anything #9279

Uh oh!

Conversation

raymondjacobson commented Jul 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Uh oh!

changeset-bot bot commented Jul 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

audius-infra commented Jul 26, 2024

Uh oh!

audius-infra commented Jul 26, 2024

Uh oh!

audius-infra commented Jul 26, 2024

Uh oh!

audius-infra commented Jul 26, 2024

Uh oh!

gitguardian bot commented Aug 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Uh oh!

audius-infra commented Aug 26, 2024

Uh oh!

raymondjacobson Aug 26, 2024

Choose a reason for hiding this comment

Uh oh!

dylanjeffers Aug 27, 2024

Choose a reason for hiding this comment

Uh oh!

raymondjacobson Aug 27, 2024

Choose a reason for hiding this comment

Uh oh!

raymondjacobson commented Aug 27, 2024

Uh oh!

audius-infra commented Aug 27, 2024

Uh oh!

audius-infra commented Aug 27, 2024

Uh oh!

audius-infra commented Aug 27, 2024

Uh oh!

dylanjeffers left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dylanjeffers Aug 27, 2024

Choose a reason for hiding this comment

Uh oh!

raymondjacobson Aug 27, 2024

Choose a reason for hiding this comment

Uh oh!

dylanjeffers Aug 27, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

audius-infra commented Aug 28, 2024

Uh oh!

audius-infra commented Aug 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

raymondjacobson commented Jul 26, 2024 •

edited

Loading

changeset-bot bot commented Jul 26, 2024 •

edited

Loading

gitguardian bot commented Aug 26, 2024 •

edited

Loading